From 042cac5fedeec8af53080b9666fe043072f3a6be Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Wed, 1 Dec 2021 15:50:01 +0800 Subject: Improve install code to avoid low-level mistakes. (#17779) * Improve install code to avoid low-level mistakes. If a user tries to do a re-install in a Gitea database, they gets a warning and double check. When Gitea runs, it never create empty app.ini automatically. Also some small (related) refactoring: * Refactor db.InitEngine related logic make it more clean (especially for the install code) * Move some i18n strings out from setting.go to make the setting.go can be easily maintained. * Show errors in CLI code if an incorrect app.ini is used. * APP_DATA_PATH is created when installing, and checked when starting (no empty directory is created any more). --- modules/doctor/doctor.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'modules/doctor/doctor.go') diff --git a/modules/doctor/doctor.go b/modules/doctor/doctor.go index 6451788f9d..20a32f1865 100644 --- a/modules/doctor/doctor.go +++ b/modules/doctor/doctor.go @@ -44,7 +44,7 @@ func (w *wrappedLevelLogger) Log(skip int, level log.Level, format string, v ... } func initDBDisableConsole(ctx context.Context, disableConsole bool) error { - setting.NewContext() + setting.LoadFromExisting() setting.InitDBConfig() setting.NewXORMLogService(disableConsole) -- cgit v1.2.3