From 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2 Mon Sep 17 00:00:00 2001 From: silverwind Date: Mon, 22 Apr 2024 13:48:42 +0200 Subject: Enable more `revive` linter rules (#30608) Noteable additions: - `redefines-builtin-id` forbid variable names that shadow go builtins - `empty-lines` remove unnecessary empty lines that `gofumpt` does not remove for some reason - `superfluous-else` eliminate more superfluous `else` branches Rules are also sorted alphabetically and I cleaned up various parts of `.golangci.yml`. --- modules/git/commit_reader.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'modules/git/commit_reader.go') diff --git a/modules/git/commit_reader.go b/modules/git/commit_reader.go index f1f4a0e588..228bbaf314 100644 --- a/modules/git/commit_reader.go +++ b/modules/git/commit_reader.go @@ -49,9 +49,8 @@ readLoop: if len(line) > 0 && line[0] == ' ' { _, _ = signatureSB.Write(line[1:]) continue - } else { - pgpsig = false } + pgpsig = false } if !message { -- cgit v1.2.3