From b8b690feb958dffb51eb1d5fc86c16996ba830e1 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 23 Dec 2024 22:29:34 -0800 Subject: Refactor getpatch/getdiff functions and remove unnecessary fallback (#32817) Extract from #32786 `git diff a..b` is equal to `git diff a b` which is different from `git diff a...b`. For pull request, we should always --------- Co-authored-by: wxiaoguang --- modules/git/repo_compare_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'modules/git/repo_compare_test.go') diff --git a/modules/git/repo_compare_test.go b/modules/git/repo_compare_test.go index 454ed6b9f8..25ee4c5198 100644 --- a/modules/git/repo_compare_test.go +++ b/modules/git/repo_compare_test.go @@ -28,7 +28,7 @@ func TestGetFormatPatch(t *testing.T) { defer repo.Close() rd := &bytes.Buffer{} - err = repo.GetPatch("8d92fc95^", "8d92fc95", rd) + err = repo.GetPatch("8d92fc95^...8d92fc95", rd) if err != nil { assert.NoError(t, err) return -- cgit v1.2.3