From 4cc63e9919486581f7acc49829ebf21bc52dd871 Mon Sep 17 00:00:00 2001 From: KN4CK3R Date: Thu, 24 Jun 2021 17:47:46 +0200 Subject: Fix diff expansion is missing final line in a file (#16222) * Fixed down offset. * Fixed wrong line count result. --- modules/git/blob.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'modules/git') diff --git a/modules/git/blob.go b/modules/git/blob.go index 732356e5b2..5831bc3735 100644 --- a/modules/git/blob.go +++ b/modules/git/blob.go @@ -34,7 +34,7 @@ func (b *Blob) GetBlobContent() (string, error) { return string(buf), nil } -// GetBlobLineCount gets line count of lob as raw text +// GetBlobLineCount gets line count of the blob func (b *Blob) GetBlobLineCount() (int, error) { reader, err := b.DataAsync() if err != nil { @@ -42,10 +42,14 @@ func (b *Blob) GetBlobLineCount() (int, error) { } defer reader.Close() buf := make([]byte, 32*1024) - count := 0 + count := 1 lineSep := []byte{'\n'} + + c, err := reader.Read(buf) + if c == 0 && err == io.EOF { + return 0, nil + } for { - c, err := reader.Read(buf) count += bytes.Count(buf[:c], lineSep) switch { case err == io.EOF: @@ -53,6 +57,7 @@ func (b *Blob) GetBlobLineCount() (int, error) { case err != nil: return count, err } + c, err = reader.Read(buf) } } -- cgit v1.2.3