From a82fd98d5368a75cbcf6b74c12f58f3f81e66662 Mon Sep 17 00:00:00 2001 From: zeripath Date: Sat, 22 Jan 2022 21:22:14 +0000 Subject: Pause queues (#15928) * Start adding mechanism to return unhandled data Signed-off-by: Andrew Thornton * Create pushback interface Signed-off-by: Andrew Thornton * Add Pausable interface to WorkerPool and Manager Signed-off-by: Andrew Thornton * Implement Pausable and PushBack for the bytefifos Signed-off-by: Andrew Thornton * Implement Pausable and Pushback for ChannelQueues and ChannelUniqueQueues Signed-off-by: Andrew Thornton * Wire in UI for pausing Signed-off-by: Andrew Thornton * add testcases and fix a few issues Signed-off-by: Andrew Thornton * fix build Signed-off-by: Andrew Thornton * prevent "race" in the test Signed-off-by: Andrew Thornton * fix jsoniter mismerge Signed-off-by: Andrew Thornton * fix conflicts Signed-off-by: Andrew Thornton * fix format Signed-off-by: Andrew Thornton * Add warnings for no worker configurations and prevent data-loss with redis/levelqueue Signed-off-by: Andrew Thornton * Use StopTimer Signed-off-by: Andrew Thornton Co-authored-by: Lauris BH Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: techknowlogick Co-authored-by: wxiaoguang --- modules/notification/ui/ui.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'modules/notification') diff --git a/modules/notification/ui/ui.go b/modules/notification/ui/ui.go index ecedd70193..a27c5f699c 100644 --- a/modules/notification/ui/ui.go +++ b/modules/notification/ui/ui.go @@ -38,13 +38,14 @@ func NewNotifier() base.Notifier { return ns } -func (ns *notificationService) handle(data ...queue.Data) { +func (ns *notificationService) handle(data ...queue.Data) []queue.Data { for _, datum := range data { opts := datum.(issueNotificationOpts) if err := models.CreateOrUpdateIssueNotifications(opts.IssueID, opts.CommentID, opts.NotificationAuthorID, opts.ReceiverID); err != nil { log.Error("Was unable to create issue notification: %v", err) } } + return nil } func (ns *notificationService) Run() { -- cgit v1.2.3