From d9ef43a7126ab83af563c1c9b54cdf0092327b2a Mon Sep 17 00:00:00 2001 From: KN4CK3R Date: Mon, 9 Aug 2021 20:08:51 +0200 Subject: Replace `list.List` with slices (#16311) * Replaced list with slice. * Fixed usage of pointer to temporary variable. * Replaced LIFO list with slice. * Lint * Removed type check. * Removed duplicated code. * Lint * Fixed merge. Co-authored-by: 6543 <6543@obermui.de> --- modules/repository/commits.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'modules/repository/commits.go') diff --git a/modules/repository/commits.go b/modules/repository/commits.go index eaaf3b8b19..7f22105745 100644 --- a/modules/repository/commits.go +++ b/modules/repository/commits.go @@ -5,7 +5,6 @@ package repository import ( - "container/list" "fmt" "time" @@ -175,12 +174,11 @@ func CommitToPushCommit(commit *git.Commit) *PushCommit { } } -// ListToPushCommits transforms a list.List to PushCommits type. -func ListToPushCommits(l *list.List) *PushCommits { - var commits []*PushCommit - for e := l.Front(); e != nil; e = e.Next() { - commit := CommitToPushCommit(e.Value.(*git.Commit)) - commits = append(commits, commit) +// GitToPushCommits transforms a list of git.Commits to PushCommits type. +func GitToPushCommits(gitCommits []*git.Commit) *PushCommits { + commits := make([]*PushCommit, 0, len(gitCommits)) + for _, commit := range gitCommits { + commits = append(commits, CommitToPushCommit(commit)) } return &PushCommits{commits, nil, "", make(map[string]string), make(map[string]*models.User)} } -- cgit v1.2.3