From 8cd46024fdcdaf04cd09be2c25db673e99b0a024 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Mon, 28 Aug 2023 13:08:19 +0800 Subject: refactor(API): refactor secret creation and update functionality (#26751) According to the GitHub API Spec: https://docs.github.com/en/rest/actions/secrets?apiVersion=2022-11-28#create-or-update-an-organization-secret Merge the Create and Update secret into a single API. - Remove the `CreateSecretOption` struct and replace it with `CreateOrUpdateSecretOption` in `modules/structs/secret.go` - Update the `CreateOrUpdateOrgSecret` function in `routers/api/v1/org/action.go` to use `CreateOrUpdateSecretOption` instead of `UpdateSecretOption` - Remove the `CreateOrgSecret` function in `routers/api/v1/org/action.go` and replace it with `CreateOrUpdateOrgSecret` - Update the Swagger documentation in `routers/api/v1/swagger/options.go` and `templates/swagger/v1_json.tmpl` to reflect the changes in the struct names and function names Signed-off-by: Bo-Yi Wu --- modules/structs/secret.go | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) (limited to 'modules/structs') diff --git a/modules/structs/secret.go b/modules/structs/secret.go index 52221b51f0..a0673ca08c 100644 --- a/modules/structs/secret.go +++ b/modules/structs/secret.go @@ -14,21 +14,9 @@ type Secret struct { Created time.Time `json:"created_at"` } -// CreateSecretOption options when creating secret +// CreateOrUpdateSecretOption options when creating or updating secret // swagger:model -type CreateSecretOption struct { - // Name of the secret to create - // - // required: true - // unique: true - Name string `json:"name" binding:"Required;AlphaDashDot;MaxSize(100)"` - // Data of the secret to create - Data string `json:"data" binding:"Required"` -} - -// UpdateSecretOption options when updating secret -// swagger:model -type UpdateSecretOption struct { +type CreateOrUpdateSecretOption struct { // Data of the secret to update // // required: true -- cgit v1.2.3