From 1f951cdebae314a45b5e4ec1d464f1b4a53c8002 Mon Sep 17 00:00:00 2001 From: David Svantesson Date: Tue, 3 Sep 2019 17:46:24 +0200 Subject: Add API endpoint for accessing repo topics (#7963) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create API endpoints for repo topics. Signed-off-by: David Svantesson * Generate swagger Signed-off-by: David Svantesson * Add documentation to functions Signed-off-by: David Svantesson * Grammar fix Signed-off-by: David Svantesson * Fix function comment Signed-off-by: David Svantesson * Can't use FindTopics when looking for a single repo topic, as it doesnt use exact match Signed-off-by: David Svantesson * Add PUT ​/repos​/{owner}​/{repo}​/topics and remove GET ​/repos​/{owner}​/{repo}​/topics * Ignore if topic is sent twice in same request, refactoring. Signed-off-by: David Svantesson * Fix topic dropdown with api changes. Signed-off-by: David Svantesson * Style fix Signed-off-by: David Svantesson * Update API documentation Signed-off-by: David Svantesson * Better way to handle duplicate topics in slice Signed-off-by: David Svantesson * Make response element TopicName an array of strings, instead of using an array of TopicName Signed-off-by: David Svantesson * Add test cases for API Repo Topics. Signed-off-by: David Svantesson * Fix format of tests Signed-off-by: David Svantesson * Fix comments Signed-off-by: David Svantesson * Fix unit tests after adding some more topics to the test fixture. Signed-off-by: David Svantesson * Update models/topic.go Limit multiple if else if ... Co-Authored-By: Antoine GIRARD * Engine as first parameter in function Co-Authored-By: Antoine GIRARD * Replace magic numbers with http status code constants. Signed-off-by: David Svantesson * Fix variable scope Signed-off-by: David Svantesson * Test one read with login and one with token Signed-off-by: David Svantesson * Add some more tests Signed-off-by: David Svantesson * Apply suggestions from code review Use empty struct for efficiency Co-Authored-By: Lauris BH * Add test case to check access for user with write access Signed-off-by: David Svantesson * Fix access, repo admin required to change topics Signed-off-by: David Svantesson * Correct first test to be without token Signed-off-by: David Svantesson * Any repo reader should be able to access topics. * No need for string pointer Signed-off-by: David Svantesson --- public/js/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'public/js') diff --git a/public/js/index.js b/public/js/index.js index 15f8d02bbd..882f19e13d 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -2936,14 +2936,14 @@ function initTopicbar() { let found = false; for (let i=0;i < res.topics.length;i++) { // skip currently added tags - if (current_topics.indexOf(res.topics[i].Name) != -1){ + if (current_topics.indexOf(res.topics[i].topic_name) != -1){ continue; } - if (res.topics[i].Name.toLowerCase() === query.toLowerCase()){ + if (res.topics[i].topic_name.toLowerCase() === query.toLowerCase()){ found_query = true; } - formattedResponse.results.push({"description": res.topics[i].Name, "data-value": res.topics[i].Name}); + formattedResponse.results.push({"description": res.topics[i].topic_name, "data-value": res.topics[i].topic_name}); found = true; } formattedResponse.success = found; -- cgit v1.2.3