From 47fd1569361a4cb474aa760cefa76c1158c5d944 Mon Sep 17 00:00:00 2001 From: zeripath Date: Tue, 4 May 2021 22:48:31 +0100 Subject: Use route rather than use thus reducing the number of stack frames (#15301) Since the move to Chi the number of stack frames has proliferated somewhat catastrophically and we're up to 96 frames with multiple tests of the url outside of a trie which is inefficient. This PR reduces the number of stack frames by 6 through careful use of Route, moves Captcha into its own router so that it only fires on Captcha routes, similarly for avatars and repo-avatars. The robots.txt, / and apple-touch-icon.png are moved out of requiring Contexter. It moves access logger higher in the stack frame because there is no reason why it can't be higher. Extract from #15186 Contains #15292 --- routers/api/v1/api.go | 4 ---- 1 file changed, 4 deletions(-) (limited to 'routers/api/v1/api.go') diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go index ecb3a3f03d..05b95d6d5f 100644 --- a/routers/api/v1/api.go +++ b/routers/api/v1/api.go @@ -572,10 +572,6 @@ func Routes() *web.Route { } m.Use(context.APIContexter()) - if setting.EnableAccessLog { - m.Use(context.AccessLogger()) - } - m.Use(context.ToggleAPI(&context.ToggleOptions{ SignInRequired: setting.Service.RequireSignInView, })) -- cgit v1.2.3