From aaeec2a3925c8e45c14179a3e6260b92e53197d2 Mon Sep 17 00:00:00 2001 From: JakobDev Date: Wed, 13 Sep 2023 04:37:54 +0200 Subject: Add missing 404 response to Swagger (#27038) Most middleware throw a 404 in case something is not found e.g. a Repo that is not existing. But most API endpoints don't include the 404 response in their documentation. This PR changes this. --- routers/api/v1/repo/milestone.go | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'routers/api/v1/repo/milestone.go') diff --git a/routers/api/v1/repo/milestone.go b/routers/api/v1/repo/milestone.go index b77fe8aca8..fff9493a23 100644 --- a/routers/api/v1/repo/milestone.go +++ b/routers/api/v1/repo/milestone.go @@ -55,6 +55,8 @@ func ListMilestones(ctx *context.APIContext) { // responses: // "200": // "$ref": "#/responses/MilestoneList" + // "404": + // "$ref": "#/responses/notFound" milestones, total, err := issues_model.GetMilestones(issues_model.GetMilestonesOption{ ListOptions: utils.GetListOptions(ctx), @@ -102,6 +104,8 @@ func GetMilestone(ctx *context.APIContext) { // responses: // "200": // "$ref": "#/responses/Milestone" + // "404": + // "$ref": "#/responses/notFound" milestone := getMilestoneByIDOrName(ctx) if ctx.Written() { @@ -138,6 +142,8 @@ func CreateMilestone(ctx *context.APIContext) { // responses: // "201": // "$ref": "#/responses/Milestone" + // "404": + // "$ref": "#/responses/notFound" form := web.GetForm(ctx).(*api.CreateMilestoneOption) if form.Deadline == nil { @@ -196,6 +202,8 @@ func EditMilestone(ctx *context.APIContext) { // responses: // "200": // "$ref": "#/responses/Milestone" + // "404": + // "$ref": "#/responses/notFound" form := web.GetForm(ctx).(*api.EditMilestoneOption) milestone := getMilestoneByIDOrName(ctx) if ctx.Written() { @@ -248,6 +256,8 @@ func DeleteMilestone(ctx *context.APIContext) { // responses: // "204": // "$ref": "#/responses/empty" + // "404": + // "$ref": "#/responses/notFound" m := getMilestoneByIDOrName(ctx) if ctx.Written() { -- cgit v1.2.3