From ea619b39b2f2a3c1fb5ad28ebd4a269b2f822111 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Thu, 18 Oct 2018 19:23:05 +0800 Subject: Add notification interface and refactor UI notifications (#5085) * add notification interface and refactor UI notifications * add missing methods on notification interface and notifiy only issue status really changed * implement NotifyPullRequestReview for ui notification --- routers/repo/pull_review.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'routers/repo/pull_review.go') diff --git a/routers/repo/pull_review.go b/routers/repo/pull_review.go index 9d1db3ff4e..91257fea33 100644 --- a/routers/repo/pull_review.go +++ b/routers/repo/pull_review.go @@ -79,7 +79,7 @@ func CreateCodeComment(ctx *context.Context, form auth.CodeCommentForm) { } // Send no notification if comment is pending if !form.IsReview { - notification.Service.NotifyIssue(issue, ctx.User.ID) + notification.NotifyCreateIssueComment(ctx.User, issue.Repo, issue, comment) } log.Trace("Comment created: %d/%d/%d", ctx.Repo.Repository.ID, issue.ID, comment.ID) @@ -184,5 +184,13 @@ func SubmitReview(ctx *context.Context, form auth.SubmitReviewForm) { ctx.ServerError("Publish", err) return } + + pr, err := issue.GetPullRequest() + if err != nil { + ctx.ServerError("GetPullRequest", err) + return + } + notification.NotifyPullRequestReview(pr, review, comm) + ctx.Redirect(fmt.Sprintf("%s/pulls/%d#%s", ctx.Repo.RepoLink, issue.Index, comm.HashTag())) } -- cgit v1.2.3