From b3d5ba6f9013052dfe51fb03ce3e2088d7da3be5 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 3 Dec 2017 01:11:22 +0800 Subject: Fix missing password length check when change password (#3039) * fix missing password length check when change password * add tests for change password --- routers/user/setting.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'routers/user/setting.go') diff --git a/routers/user/setting.go b/routers/user/setting.go index bd2c923b70..a2f32e3e19 100644 --- a/routers/user/setting.go +++ b/routers/user/setting.go @@ -222,7 +222,9 @@ func SettingsSecurityPost(ctx *context.Context, form auth.ChangePasswordForm) { return } - if ctx.User.IsPasswordSet() && !ctx.User.ValidatePassword(form.OldPassword) { + if len(form.Password) < setting.MinPasswordLength { + ctx.Flash.Error(ctx.Tr("auth.password_too_short", setting.MinPasswordLength)) + } else if ctx.User.IsPasswordSet() && !ctx.User.ValidatePassword(form.OldPassword) { ctx.Flash.Error(ctx.Tr("settings.password_incorrect")) } else if form.Password != form.Retype { ctx.Flash.Error(ctx.Tr("form.password_not_match")) -- cgit v1.2.3