From 2a828e2798d5f77e768e1199d88a00996bd3e45a Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Tue, 24 Dec 2024 21:47:45 +0800 Subject: Clarify path param naming (#32969) In history (from some legacy frameworks), both `:name` and `name` are supported as path path name, `:name` is an alias to `name`. To make code consistent, now we should only use `name` but not `:name`. Also added panic check in related functions to make sure the name won't be abused in case some downstreams still use them. --- routers/web/feed/render.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'routers/web/feed') diff --git a/routers/web/feed/render.go b/routers/web/feed/render.go index f975fc7cb2..462ebb97b5 100644 --- a/routers/web/feed/render.go +++ b/routers/web/feed/render.go @@ -9,7 +9,7 @@ import ( // RenderBranchFeed render format for branch or file func RenderBranchFeed(ctx *context.Context) { - _, _, showFeedType := GetFeedType(ctx.PathParam(":reponame"), ctx.Req) + _, _, showFeedType := GetFeedType(ctx.PathParam("reponame"), ctx.Req) if ctx.Repo.TreePath == "" { ShowBranchFeed(ctx, ctx.Repo.Repository, showFeedType) } else { -- cgit v1.2.3