From bc861347597a88ed476ec0124c4c4baf773255c3 Mon Sep 17 00:00:00 2001 From: Mario Lubenka Date: Sat, 20 Apr 2019 22:50:34 +0200 Subject: Show "delete branch" button on closed pull requests (#6570) (#6601) * Show button to delete a pull request branch after a pull request has been closed (#6570) Signed-off-by: Mario Lubenka * Update routers/repo/pull.go Co-Authored-By: saitho --- routers/repo/issue.go | 1 + routers/repo/pull.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'routers') diff --git a/routers/repo/issue.go b/routers/repo/issue.go index c818ac4840..7a681033af 100644 --- a/routers/repo/issue.go +++ b/routers/repo/issue.go @@ -674,6 +674,7 @@ func ViewIssue(ctx *context.Context) { PrepareMergedViewPullInfo(ctx, issue) } else { PrepareViewPullInfo(ctx, issue) + ctx.Data["DisableStatusChange"] = ctx.Data["IsPullRequestBroken"] == true && issue.IsClosed } if ctx.Written() { return diff --git a/routers/repo/pull.go b/routers/repo/pull.go index 14ab2207b5..0616ee2c77 100644 --- a/routers/repo/pull.go +++ b/routers/repo/pull.go @@ -999,8 +999,8 @@ func CleanUpPullRequest(ctx *context.Context) { pr := issue.PullRequest - // Allow cleanup only for merged PR - if !pr.HasMerged { + // Don't cleanup unmerged and unclosed PRs + if !pr.HasMerged && !issue.IsClosed { ctx.NotFound("CleanUpPullRequest", nil) return } -- cgit v1.2.3