From eb36a4554ee9a9d15954f08dd37deee54385e29c Mon Sep 17 00:00:00 2001 From: TheFox0x7 Date: Fri, 27 Jun 2025 07:59:55 +0200 Subject: enforce nolint scope (#34851) enable nolintlint scope requirement add comments to new directives so it's more obvious why they are in place --- I can also toggle the mandatory comments on if that's something of interest. --------- Co-authored-by: wxiaoguang Co-authored-by: Giteabot --- services/gitdiff/gitdiff.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'services/gitdiff/gitdiff.go') diff --git a/services/gitdiff/gitdiff.go b/services/gitdiff/gitdiff.go index 010040bc70..f85b13e97f 100644 --- a/services/gitdiff/gitdiff.go +++ b/services/gitdiff/gitdiff.go @@ -1356,7 +1356,7 @@ func SyncUserSpecificDiff(ctx context.Context, userID int64, pull *issues_model. // But as that does not work for all potential errors, we simply mark all files as unchanged and drop the error which always works, even if not as good as possible if err != nil { log.Error("Could not get changed files between %s and %s for pull request %d in repo with path %s. Assuming no changes. Error: %w", review.CommitSHA, latestCommit, pull.Index, gitRepo.Path, err) - err = nil //nolint + err = nil //nolint:ineffassign,wastedassign } filesChangedSinceLastDiff := make(map[string]pull_model.ViewedState) -- cgit v1.2.3