From dc04044716088e3786497e200abe1fdfb3a943b6 Mon Sep 17 00:00:00 2001 From: Nanguan Lin <70063547+lng2020@users.noreply.github.com> Date: Wed, 11 Oct 2023 19:02:24 +0800 Subject: Replace assert.Fail with assert.FailNow (#27578) assert.Fail() will continue to execute the code while assert.FailNow() not. I thought those uses of assert.Fail() should exit immediately. PS: perhaps it's a good idea to use [require](https://pkg.go.dev/github.com/stretchr/testify/require) somewhere because the assert package's default behavior does not exit when an error occurs, which makes it difficult to find the root error reason. --- services/pull/check_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'services/pull') diff --git a/services/pull/check_test.go b/services/pull/check_test.go index 4a99859f5a..dcf5f7b93a 100644 --- a/services/pull/check_test.go +++ b/services/pull/check_test.go @@ -54,7 +54,7 @@ func TestPullRequest_AddToTaskQueue(t *testing.T) { case id := <-idChan: assert.EqualValues(t, pr.ID, id) case <-time.After(time.Second): - assert.Fail(t, "Timeout: nothing was added to pullRequestQueue") + assert.FailNow(t, "Timeout: nothing was added to pullRequestQueue") } has, err = prPatchCheckerQueue.Has(strconv.FormatInt(pr.ID, 10)) -- cgit v1.2.3