From eceab9e26f671318d3b50e622736a514f384aee6 Mon Sep 17 00:00:00 2001 From: Norwin Date: Tue, 8 Mar 2022 22:48:47 +0100 Subject: Allow users to self-request a PR review (#19030) The review request feature was added in https://github.com/go-gitea/gitea/pull/10756, where the doer got explicitly excluded from available reviewers. I don't see a functionality or security related reason to forbid this case. As shown by GitHubs implementation, it may be useful to self-request a review, to be reminded oneselves about reviewing, while communicating to team mates that a review is missing. Co-authored-by: delvh --- services/issue/assignee.go | 8 -------- 1 file changed, 8 deletions(-) (limited to 'services') diff --git a/services/issue/assignee.go b/services/issue/assignee.go index 4fdf0029c8..f09c51293b 100644 --- a/services/issue/assignee.go +++ b/services/issue/assignee.go @@ -140,14 +140,6 @@ func IsValidReviewRequest(reviewer, doer *user_model.User, isAdd bool, issue *mo } } - if doer.ID == reviewer.ID { - return models.ErrNotValidReviewRequest{ - Reason: "doer can't be reviewer", - UserID: doer.ID, - RepoID: issue.Repo.ID, - } - } - if reviewer.ID == issue.PosterID && issue.OriginalAuthorID == 0 { return models.ErrNotValidReviewRequest{ Reason: "poster of pr can't be reviewer", -- cgit v1.2.3