From 48e3e38ee040c9cfec6ea2adea2da49a7f21f2c7 Mon Sep 17 00:00:00 2001
From: wxiaoguang <wxiaoguang@gmail.com>
Date: Thu, 4 May 2023 02:32:10 +0800
Subject: Clean up polluted styles and remove dead CSS code (#24497)

Follow #24393


The funny history:

* At the beginning, `.ui.message` was polluted by `text-align: center`
* Then people do `<div class="ui ... message text left">`
* But `.ui.left` is polluted by `float: left`
* Then people do `#xxx .ui.message { width: 100% !important;}`

The code just becomes more and more hacky.

After removing the pollution,  everything becomes clear and straight.


And, this PR also does:

1. Remove the `package.css`, its styles could be provided by `top
aligned`
2. Remove `#avatar-arrow`, dead code



Screenshot:


![image](https://user-images.githubusercontent.com/2114189/235862130-a9eb5d8f-7d01-457c-99f7-21d0abc3075e.png)


![image](https://user-images.githubusercontent.com/2114189/235862222-139709a7-95c2-4f89-a40f-100b2d76d9bb.png)

Co-authored-by: Giteabot <teabot@gitea.io>
---
 templates/repo/issue/view_content/pull.tmpl    |  2 +-
 templates/repo/issue/view_content/sidebar.tmpl |  2 +-
 templates/repo/migrate/migrating.tmpl          |  2 +-
 templates/repo/settings/options.tmpl           | 10 +++++-----
 4 files changed, 8 insertions(+), 8 deletions(-)

(limited to 'templates/repo')

diff --git a/templates/repo/issue/view_content/pull.tmpl b/templates/repo/issue/view_content/pull.tmpl
index ec957161b1..29d8d9d47c 100644
--- a/templates/repo/issue/view_content/pull.tmpl
+++ b/templates/repo/issue/view_content/pull.tmpl
@@ -47,7 +47,7 @@
 										{{$.locale.Tr "repo.issues.dismiss_review"}}
 									</div>
 									<div class="content">
-										<div class="ui warning message text left">
+										<div class="ui warning message">
 											{{$.locale.Tr "repo.issues.dismiss_review_warning"}}
 										</div>
 										<form class="ui form dismiss-review-form" id="dismiss-review-{{.Review.ID}}" action="{{$.RepoLink}}/issues/dismiss_review" method="post">
diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl
index e07ef0fa37..86796a91cb 100644
--- a/templates/repo/issue/view_content/sidebar.tmpl
+++ b/templates/repo/issue/view_content/sidebar.tmpl
@@ -560,7 +560,7 @@
 					{{end}}
 				</div>
 				<div class="content">
-					<div class="ui warning message text left">
+					<div class="ui warning message">
 						{{if .Issue.IsLocked}}
 							{{.locale.Tr "repo.issues.unlock.notice_1"}}<br>
 							{{.locale.Tr "repo.issues.unlock.notice_2"}}<br>
diff --git a/templates/repo/migrate/migrating.tmpl b/templates/repo/migrate/migrating.tmpl
index 51caa28aa1..72c3fe5664 100644
--- a/templates/repo/migrate/migrating.tmpl
+++ b/templates/repo/migrate/migrating.tmpl
@@ -50,7 +50,7 @@
 		{{.locale.Tr "repo.settings.delete"}}
 	</div>
 	<div class="content">
-		<div class="ui warning message text left">
+		<div class="ui warning message">
 			{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}<br>
 			{{.locale.Tr "repo.settings.delete_notices_2" .Repository.FullName | Safe}}
 			{{if .Repository.NumForks}}<br>
diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl
index 515854609a..af753ba670 100644
--- a/templates/repo/settings/options.tmpl
+++ b/templates/repo/settings/options.tmpl
@@ -803,7 +803,7 @@
 				{{.locale.Tr "repo.settings.convert"}}
 			</div>
 			<div class="content">
-				<div class="ui warning message text left">
+				<div class="ui warning message">
 					{{.locale.Tr "repo.settings.convert_notices_1"}}
 				</div>
 				<form class="ui form" action="{{.Link}}" method="post">
@@ -834,7 +834,7 @@
 				{{.locale.Tr "repo.settings.convert_fork"}}
 			</div>
 			<div class="content">
-				<div class="ui warning message text left">
+				<div class="ui warning message">
 					{{.locale.Tr "repo.settings.convert_fork_notices_1"}}
 				</div>
 				<form class="ui form" action="{{.Link}}" method="post">
@@ -864,7 +864,7 @@
 			{{.locale.Tr "repo.settings.transfer"}}
 		</div>
 		<div class="content">
-			<div class="ui warning message text left">
+			<div class="ui warning message">
 				{{.locale.Tr "repo.settings.transfer_notices_1"}} <br>
 				{{.locale.Tr "repo.settings.transfer_notices_2"}} <br>
 				{{.locale.Tr "repo.settings.transfer_notices_3"}}
@@ -900,7 +900,7 @@
 			{{.locale.Tr "repo.settings.delete"}}
 		</div>
 		<div class="content">
-			<div class="ui warning message text left">
+			<div class="ui warning message">
 				{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}<br>
 				{{.locale.Tr "repo.settings.delete_notices_2" .Repository.FullName | Safe}}
 				{{if .Repository.NumForks}}<br>
@@ -935,7 +935,7 @@
 			{{.locale.Tr "repo.settings.wiki_delete"}}
 		</div>
 		<div class="content">
-			<div class="ui warning message text left">
+			<div class="ui warning message">
 				{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}<br>
 				{{.locale.Tr "repo.settings.wiki_delete_notices_1" .Repository.Name | Safe}}
 			</div>
-- 
cgit v1.2.3