From a159c3175f5f60a9de00f4d3c73787ffa6c63ddd Mon Sep 17 00:00:00 2001 From: silverwind Date: Mon, 22 Nov 2021 09:19:01 +0100 Subject: Add new JS linter rules (#17699) * Add new JS linter rules Adds a few useful rules from eslint-plugin-github. Notable changes: - Forbid dataset usage, its camel-casing behaviour makes it hard to grep for attributes. - Forbid .then() and .catch(), we should generally prefer await for new code. For rare cases where they are useful, a eslint-disable-line directive can be set. - Add docs js to linting * also enable github/array-foreach * small tweak Co-authored-by: Andrew Thornton Co-authored-by: techknowlogick Co-authored-by: wxiaoguang --- templates/repo/clone_buttons.tmpl | 2 +- templates/repo/empty.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'templates') diff --git a/templates/repo/clone_buttons.tmpl b/templates/repo/clone_buttons.tmpl index 218eb31cb6..29d3fe76d7 100644 --- a/templates/repo/clone_buttons.tmpl +++ b/templates/repo/clone_buttons.tmpl @@ -24,7 +24,7 @@ const sshButton = document.getElementById('repo-clone-ssh'); const httpsButton = document.getElementById('repo-clone-https'); const input = document.getElementById('repo-clone-url'); - if (input) input.value = (isSSH ? sshButton : httpsButton).dataset.link; + if (input) input.value = (isSSH ? sshButton : httpsButton).getAttribute('data-link'); if (sshButton) sshButton.classList[isSSH ? 'add' : 'remove']('primary'); if (httpsButton) httpsButton.classList[isSSH ? 'remove' : 'add']('primary'); setTimeout(() => { diff --git a/templates/repo/empty.tmpl b/templates/repo/empty.tmpl index 485a6aa4e5..20563f59e6 100644 --- a/templates/repo/empty.tmpl +++ b/templates/repo/empty.tmpl @@ -51,7 +51,7 @@ git push -u origin {{.Repository.DefaultBranch}} const cloneUrls = document.getElementsByClassName('clone-url'); if (cloneUrls) { for (let i = 0; i < cloneUrls.length; i++) { - cloneUrls[i].textContent = (isSSH ? sshButton : httpsButton).dataset.link; + cloneUrls[i].textContent = (isSSH ? sshButton : httpsButton).getAttribute('data-link'); } } -- cgit v1.2.3