From a159c3175f5f60a9de00f4d3c73787ffa6c63ddd Mon Sep 17 00:00:00 2001 From: silverwind Date: Mon, 22 Nov 2021 09:19:01 +0100 Subject: Add new JS linter rules (#17699) * Add new JS linter rules Adds a few useful rules from eslint-plugin-github. Notable changes: - Forbid dataset usage, its camel-casing behaviour makes it hard to grep for attributes. - Forbid .then() and .catch(), we should generally prefer await for new code. For rare cases where they are useful, a eslint-disable-line directive can be set. - Add docs js to linting * also enable github/array-foreach * small tweak Co-authored-by: Andrew Thornton Co-authored-by: techknowlogick Co-authored-by: wxiaoguang --- web_src/js/features/repo-legacy.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'web_src/js/features/repo-legacy.js') diff --git a/web_src/js/features/repo-legacy.js b/web_src/js/features/repo-legacy.js index d8530fe24f..5904b3ce22 100644 --- a/web_src/js/features/repo-legacy.js +++ b/web_src/js/features/repo-legacy.js @@ -162,7 +162,7 @@ export function initRepoCommentForm() { 'clear', $listMenu.data('issue-id'), '', - ).then(() => window.location.reload()); + ).then(() => window.location.reload()); // eslint-disable-line github/no-then } $(this).parent().find('.item').each(function () { @@ -205,7 +205,7 @@ export function initRepoCommentForm() { '', $menu.data('issue-id'), $(this).data('id'), - ).then(() => window.location.reload()); + ).then(() => window.location.reload()); // eslint-disable-line github/no-then } let icon = ''; @@ -238,7 +238,7 @@ export function initRepoCommentForm() { '', $menu.data('issue-id'), $(this).data('id'), - ).then(() => window.location.reload()); + ).then(() => window.location.reload()); // eslint-disable-line github/no-then } $list.find('.selected').html(''); -- cgit v1.2.3