From 48ef04ee56272da4c8c8fd96b8af13fe82cd8e37 Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 4 Apr 2021 22:37:50 +0100 Subject: Drop the event source if we are unauthorized (#15275) A previous commit that sent unauthorized if the user is unauthorized simply leads to the repeated reopening of the eventsource. # This PR changes the event returned to tell the client to close the eventsource and thus prevents the repeated reopening. Signed-off-by: Andrew Thornton --- web_src/js/features/eventsource.sharedworker.js | 1 + web_src/js/features/notification.js | 5 +++++ web_src/js/features/stopwatch.js | 5 +++++ 3 files changed, 11 insertions(+) (limited to 'web_src/js/features') diff --git a/web_src/js/features/eventsource.sharedworker.js b/web_src/js/features/eventsource.sharedworker.js index 6a6ee154db..ff160cdc52 100644 --- a/web_src/js/features/eventsource.sharedworker.js +++ b/web_src/js/features/eventsource.sharedworker.js @@ -10,6 +10,7 @@ class Source { this.listening = {}; this.clients = []; this.listen('open'); + this.listen('close'); this.listen('logout'); this.listen('notification-count'); this.listen('stopwatches'); diff --git a/web_src/js/features/notification.js b/web_src/js/features/notification.js index a0793d2286..fca1ddc543 100644 --- a/web_src/js/features/notification.js +++ b/web_src/js/features/notification.js @@ -74,6 +74,11 @@ export async function initNotificationCount() { }); worker.port.close(); window.location.href = AppSubUrl; + } else if (event.data.type === 'close') { + worker.port.postMessage({ + type: 'close', + }); + worker.port.close(); } }); worker.port.addEventListener('error', (e) => { diff --git a/web_src/js/features/stopwatch.js b/web_src/js/features/stopwatch.js index 61f19bd795..9352ef292d 100644 --- a/web_src/js/features/stopwatch.js +++ b/web_src/js/features/stopwatch.js @@ -55,6 +55,11 @@ export async function initStopwatch() { }); worker.port.close(); window.location.href = AppSubUrl; + } else if (event.data.type === 'close') { + worker.port.postMessage({ + type: 'close', + }); + worker.port.close(); } }); worker.port.addEventListener('error', (e) => { -- cgit v1.2.3