From 14c142b0bca2af79f30fcf221479fb66d63dbdf8 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sun, 30 Apr 2023 23:51:20 +0800 Subject: Improve issue list filter (#24425) Partial regression of #24393, not only regression, but broken for long time, 24393 didn't really improve it but used wrong `overflow: scroll`. Actually, that "ui secondary filter menu labels" shouldn't be set as scrollable (I missed that at that time), the problem is: if a "ui menu" has "dropdown" items, then it should not be scrollable. Otherwise the dropdown menu can't be shown correctly. And there are more problems: * The "issue-filters" shouldn't be used anywhere else (copying&pasting problem again ....) * There is also an "issue-actions" container, it should also be fixed. * There are similar problems on the milestone page. * The old comment in code: "grid column" doesn't work well. The major changes of this PR are: use "flex: 1" instead of "ui grid column". After this PR, not 100% perfect but much better than before. --- web_src/js/features/repo-issue-list.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'web_src/js') diff --git a/web_src/js/features/repo-issue-list.js b/web_src/js/features/repo-issue-list.js index 915cd2e132..af0e80af81 100644 --- a/web_src/js/features/repo-issue-list.js +++ b/web_src/js/features/repo-issue-list.js @@ -23,7 +23,7 @@ function initRepoIssueListCheckboxes() { toggleElem($('#issue-filters'), !anyChecked); toggleElem($('#issue-actions'), anyChecked); // there are two panels but only one select-all checkbox, so move the checkbox to the visible panel - $('#issue-filters, #issue-actions').filter(':visible').find('.column:first').prepend($issueSelectAll); + $('#issue-filters, #issue-actions').filter(':visible').find('.issue-list-toolbar-left').prepend($issueSelectAll); }; $issueCheckboxes.on('change', syncIssueSelectionState); -- cgit v1.2.3