From 66a9ef90362db1280808ff74e40c2e670f992fcb Mon Sep 17 00:00:00 2001 From: Sijmen Schoon Date: Fri, 15 May 2020 00:55:43 +0200 Subject: Fix ref links in issue overviews for tags (#8742) * Properly generate ref URLs Tags used to not generate correct URLs (src/branch/tags/1.0.0 instead of src/tags/1.0.0). Also cleans up some code around it with the created helper functions. * Fix formatting and create migration * Add copyright head to utils_test * Use a raw query for the ref migration * Remove semicolon * Quote column and table names in migration SQL * Change || to CONCAT, since MSSQL does not support || * Make migration engine aware * Add missing import * Move ref EndName and URL to the issue service * Fix tests * Add test for commit refs * Update issue.go * Use the right command for building JavaScript bundles * Prepare for merge * Check for refs/* before prepending in migration * Update services/issue/issue_test.go * Update modules/git/utils_test.go Co-authored-by: techknowlogick Co-authored-by: techknowlogick --- web_src/js/index.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'web_src/js') diff --git a/web_src/js/index.js b/web_src/js/index.js index c7b8934874..91d16192de 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -114,10 +114,9 @@ function initEditForm() { function initBranchSelector() { const $selectBranch = $('.ui.select-branch'); const $branchMenu = $selectBranch.find('.reference-list-menu'); - $branchMenu.find('.item:not(.no-select)').on('click', function () { - const selectedValue = $(this).data('id'); - $($(this).data('id-selector')).val(selectedValue); - $selectBranch.find('.ui .branch-name').text(selectedValue); + $branchMenu.find('.item:not(.no-select)').click(function () { + $($(this).data('id-selector')).val($(this).data('id')); + $selectBranch.find('.ui .branch-name').text($(this).data('name')); }); $selectBranch.find('.reference.column').on('click', function () { $selectBranch.find('.scrolling.reference-list-menu').css('display', 'none'); -- cgit v1.2.3