From 7eb846013299465e4cd73f76f13a00984183146e Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 11 Oct 2020 00:49:59 +0100 Subject: Fix attachments list in edit comment (#13036) #11141 broke the appearance of dropzone attachments when editting comments causing poorly updating lists. This PR fixes this. Fix #12583 Signed-off-by: Andrew Thornton art27@cantab.net --- web_src/js/index.js | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) (limited to 'web_src/js') diff --git a/web_src/js/index.js b/web_src/js/index.js index e4f1575391..e1fd24f37c 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -940,7 +940,7 @@ async function initRepository() { dz.removeAllFiles(true); $files.empty(); $.each(data, function () { - const imgSrc = `${$dropzone.data('upload-url')}/${this.uuid}`; + const imgSrc = `${$dropzone.data('link-url')}/${this.uuid}`; dz.emit('addedfile', this); dz.emit('thumbnail', this, imgSrc); dz.emit('complete', this); @@ -976,7 +976,9 @@ async function initRepository() { $editContentZone.find('.cancel.button').on('click', () => { $renderContent.show(); $editContentZone.hide(); - dz.emit('reload'); + if (dz) { + dz.emit('reload'); + } }); $editContentZone.find('.save.button').on('click', () => { $renderContent.show(); @@ -990,26 +992,32 @@ async function initRepository() { context: $editContentZone.data('context'), files: $attachments }, (data) => { - if (data.length === 0) { + if (data.length === 0 || data.content.length === 0) { $renderContent.html($('#no-content').html()); } else { $renderContent.html(data.content); } - const $content = $segment.parent(); - if (!$content.find('.ui.small.images').length) { + const $content = $segment; + if (!$content.find('.dropzone-attachments').length) { if (data.attachments !== '') { - $content.append( - '
' - ); - $content.find('.ui.small.images').html(data.attachments); + $content.append(` +
+
+
+
+
+ `); + $content.find('.dropzone-attachments .grid').html(data.attachments); } } else if (data.attachments === '') { - $content.find('.ui.small.images').parent().remove(); + $content.find('.dropzone-attachments').remove(); } else { - $content.find('.ui.small.images').html(data.attachments); + $content.find('.dropzone-attachments .grid').html(data.attachments); + } + if (dz) { + dz.emit('submit'); + dz.emit('reload'); } - dz.emit('submit'); - dz.emit('reload'); renderMarkdownContent(); }); }); -- cgit v1.2.3