From 8e89eb8f43eb99694d1fdb0d069016db1d3f837e Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 20 Jun 2023 07:38:52 +0200 Subject: Update JS dependencies, remove space after emoji completion (#25266) (#25352) Manual backport of #25266 because of lockfile conflicts. - Update all JS dependencies - Enable stylint [`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown) - Make use of new features in webpack and text-expander-element - Tested Swagger and Mermaid To explain the `text-expander-element` change: Before this version, the element added a unavoidable space after emoji completion. Now that https://github.com/github/text-expander-element/pull/36 is in, we gain control over this space and I opted to remove it for emoji completion and retain it for `@` mentions. Co-authored-by: Giteabot --- web_src/js/features/comp/TextExpander.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'web_src/js') diff --git a/web_src/js/features/comp/TextExpander.js b/web_src/js/features/comp/TextExpander.js index e2840610df..128a2ddff0 100644 --- a/web_src/js/features/comp/TextExpander.js +++ b/web_src/js/features/comp/TextExpander.js @@ -53,7 +53,9 @@ export function initTextExpander(expander) { }); expander?.addEventListener('text-expander-value', ({detail}) => { if (detail?.item) { - detail.value = detail.item.getAttribute('data-value'); + // add a space after @mentions as it's likely the user wants one + const suffix = detail.key === '@' ? ' ' : ''; + detail.value = `${detail.item.getAttribute('data-value')}${suffix}`; } }); } -- cgit v1.2.3