From 0fe2debf0013cd964d2073438792b3aec598993c Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 12:14:21 +0100
Subject: Make clip-animation extend properties-animation, so as we can mix
 clip effects with any other property. Fixed some issues in this class as well

---
 .../client/plugins/effects/ClipAnimation.java      | 69 +++++++++++++---------
 1 file changed, 41 insertions(+), 28 deletions(-)

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
index e81e6340..b38e4747 100755
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
@@ -15,16 +15,17 @@
  */
 package com.google.gwt.query.client.plugins.effects;
 
+
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.query.client.Function;
 import com.google.gwt.query.client.GQuery;
+import com.google.gwt.query.client.Properties;
 import com.google.gwt.query.client.plugins.Effects;
-import com.google.gwt.query.client.plugins.Effects.GQAnimation;
 
 /**
- * Animation wich uses the css clip property to show/hide an element.
+ * Animation which uses the css clip property to show/hide an element.
  */
-public class ClipAnimation extends GQAnimation {
+public class ClipAnimation extends PropertiesAnimation {
 
   /**
    * Type of the effect action.
@@ -48,7 +49,7 @@ public class ClipAnimation extends GQAnimation {
   }
 
   private static final String[] attrsToSave = new String[]{
-      "position", "overflow", "visibility", "white-space", "top", "left"};
+      "position", "overflow", "visibility", "white-space", "top", "left", "width", "height"};
 
   Action action;
   Corner corner;
@@ -58,8 +59,8 @@ public class ClipAnimation extends GQAnimation {
   private Function[] funcs;
   private Effects g;
 
-  public ClipAnimation(Element elem, Action a, Corner c, Direction d,
-      final Function... funcs) {
+  public ClipAnimation(Element elem, Action a, Corner c, Direction d, Easing easing,  Properties p, final Function... funcs) {
+    super(easing, elem, p, funcs);
     if (a == Action.TOGGLE) {
       a = GQuery.$(elem).isVisible() ? Action.HIDE : Action.SHOW;
     }
@@ -71,6 +72,10 @@ public class ClipAnimation extends GQAnimation {
     g = GQuery.$(e).as(Effects.Effects);
   }
 
+  public ClipAnimation(Element elem, Action a, Corner c, Direction d, final Function... funcs) {
+    this(elem, a, c, d, null, Properties.create(), funcs);
+  }
+
   @Override
   public void onCancel() {
     Boolean jumpToEnd = Effects.$(e).data(Effects.JUMP_TO_END, Boolean.class);
@@ -97,49 +102,57 @@ public class ClipAnimation extends GQAnimation {
 
   @Override
   public void onStart() {
+    super.onStart();
     g.show();
     g.saveCssAttrs(attrsToSave);
-    if (!"absolute".equalsIgnoreCase(g.css("position", true))) {
-      g.css("position", "absolute");
-      g.css("top", g.offset().top + "px");
-      g.css("left", g.offset().left + "px");
+
+    // CSS clip only works with absolute/fixed positioning
+    if (!g.css("position", true).matches("absolute|fixed")) {
+      // Add a temporary element to replace the original one, so nothing is moved when
+      // setting the absolute  position to our element
       back = back.add(g.before("<div></div>")).prev();
       back.height(g.height());
       back.width(g.width());
+      // change the position property, but keeping its original position and sizes
+      g.css("top", g.offset().top + "px");
+      g.css("left", g.offset().left + "px");
+      g.css("width", g.width() + "px");
+      g.css("height", g.height() + "px");
+      g.css("position", "absolute");
     }
     g.css("overflow", "hidden");
     g.css("visivility", "visible");
-    super.onStart();
   }
 
   @Override
   public void onUpdate(double progress) {
+    super.onUpdate(progress);
+
     if (action == Action.HIDE) {
       progress = (1 - progress);
     }
-    int top = 0;
-    int left = 0;
-    int right = g.width();
-    int bottom = g.height();
+    int w = g.outerWidth(), h = g.outerHeight();
+    int top = 0, left = 0, right = w, bottom = h;
 
     if (direction == Direction.VERTICAL || direction == Direction.BIDIRECTIONAL) {
-      bottom = (int) (g.height() * progress);
+      bottom = (int) (h * progress);
     }
-    if (direction == Direction.HORIZONTAL
-        || direction == Direction.BIDIRECTIONAL) {
-      right = (int) (g.width() * progress);
+    if (direction == Direction.HORIZONTAL || direction == Direction.BIDIRECTIONAL) {
+      right = (int) (w * progress);
     }
     if (corner == Corner.CENTER) {
-      top = (g.height() - bottom) / 2;
-      left = (g.width() - right) / 2;
-    } else if (corner == Corner.BOTTOM_LEFT) {
-      top = (g.height() - bottom);
-    } else if (corner == Corner.TOP_RIGHT) {
-      left = (g.width() - right);
-    } else if (corner == Corner.BOTTOM_RIGHT) {
-      left = (g.width() - right);
-      top = (g.height() - bottom);
+      top = (h - bottom) / 2;
+      left = (w - right) / 2;
+    }
+    if (corner == Corner.TOP_RIGHT || corner == Corner.BOTTOM_RIGHT) {
+      left = (w - right);
+      right = w;
     }
+    if (corner == Corner.BOTTOM_LEFT || corner == Corner.BOTTOM_RIGHT) {
+      top = (h - bottom);
+      bottom = h;
+    }
+
     String rect = top + "px " + right + "px " + bottom + "px  " + left + "px";
     g.css("clip", "rect(" + rect + ")");
   }
-- 
cgit v1.2.3


From 5f3474f1e610f7bddb2dc847cc1a52bf6d4cec5f Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 15:15:19 +0100
Subject: Adding missing method in widgets, and javadocs

---
 .../com/google/gwt/query/client/plugins/Widgets.java | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/Widgets.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/Widgets.java
index 7e7f3462..6367e7b7 100755
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/Widgets.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/Widgets.java
@@ -110,10 +110,7 @@ public class Widgets extends QueuePlugin<Widgets> {
   }
 
   /**
-   * Create a {@link Button} widget for each selected element. The
-   * <code>initializers</code> will be called on each new {@link Button} created
-   * by passing them in parameter.
-   *
+   * Create a {@link Button} widget for each selected element.
    */
   public Widgets button() {
     return widgets(new ButtonWidgetFactory(), null);
@@ -129,10 +126,25 @@ public class Widgets extends QueuePlugin<Widgets> {
     return widgets(new ButtonWidgetFactory(), initializers);
   }
 
+  /**
+   * Create a {@link Panel} widget for each selected element.
+   */
   public Widgets panel() {
     return widgets(new HtmlPanelWidgetFactory(), null);
   }
 
+  /**
+   * Create a {@link Label} widget for each selected element.
+   */
+  public Widgets label() {
+    return widgets(new LabelWidgetFactory(), null);
+  }
+  
+  /**
+   * Create a {@link Label} widget for each selected element. The
+   * <code>initializers</code> will be called on each new {@link Label} created
+   * by passing them in parameter.
+   */
   public Widgets label(WidgetInitializer<Label> initializers) {
     return widgets(new LabelWidgetFactory(), initializers);
   }
-- 
cgit v1.2.3


From 00a9035774e41fcc38ae42af363e64c9777f6ba6 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 15:21:27 +0100
Subject: Adding a TransitionsAnimation class whish is like PropertiesAnimation
 but using CSS3

---
 .../gwt/query/client/plugins/effects/Fx.java       |  23 ++++
 .../plugins/effects/PropertiesAnimation.java       |  30 ++---
 .../query/client/plugins/effects/Transitions.java  |  61 ++++++---
 .../plugins/effects/TransitionsAnimation.java      | 147 +++++++++++++++++++++
 4 files changed, 227 insertions(+), 34 deletions(-)
 create mode 100755 gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
index 03ed86b0..426c408d 100644
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
@@ -18,6 +18,29 @@ public class Fx {
    */
   public static boolean off = false;
 
+  /**
+   * A pojo to store color transition values.
+   */
+  public static class TransitFx extends Fx {
+    public String transitEnd;
+    public String transitStart;
+
+    TransitFx() {
+    }
+
+    TransitFx(String attr, String value, String start, String end, String unit) {
+      this.cssprop = attr;
+      this.value = value;
+      this.transitStart = start;
+      this.transitEnd = end;
+      this.unit = unit;
+    }
+
+    public String toString() {
+      return super.toString() + " transitStart=" + transitStart + " transitEnd=" + transitEnd; 
+    }
+  }
+
   /**
    * A pojo to store color effect values.
    */
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/PropertiesAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/PropertiesAnimation.java
index f91f0557..d9404e22 100755
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/PropertiesAnimation.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/PropertiesAnimation.java
@@ -15,6 +15,8 @@
  */
 package com.google.gwt.query.client.plugins.effects;
 
+import static com.google.gwt.query.client.GQuery.$;
+
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.query.client.Function;
 import com.google.gwt.query.client.GQuery;
@@ -131,13 +133,13 @@ public class PropertiesAnimation extends GQAnimation {
      }
    }
 
-  private static final String[] ATTRS_TO_SAVE = new String[]{"overflow"};
+  protected static final String[] ATTRS_TO_SAVE = new String[]{"overflow"};
   
   private static final RegExp REGEX_NUMBER_UNIT = RegExp.compile("^([0-9+-.]+)(.*)?$");
 
-  private static final RegExp REGEX_SYMBOL_NUMBER_UNIT = RegExp.compile("^([+-]=)?([0-9+-.]+)(.*)?$");
+  protected static final RegExp REGEX_SYMBOL_NUMBER_UNIT = RegExp.compile("^([+-]=)?([0-9+-.]+)(.*)?$");
 
-  private static final RegExp REGEX_NON_PIXEL_ATTRS = 
+  protected static final RegExp REGEX_NON_PIXEL_ATTRS = 
       RegExp.compile("z-?index|font-?weight|opacity|zoom|line-?height|^\\$", "i");
 
   private static final RegExp REGEX_COLOR_ATTR = RegExp.compile(".*color$", "i");
@@ -266,21 +268,19 @@ public class PropertiesAnimation extends GQAnimation {
     return new Fx(key, val, start, end, unit, rkey);
   }
 
-  private Easing easing = EasingCurve.linear;
-  private JsObjectArray<Fx> effects = JsObjectArray.create();
-  private Function[] funcs;
+  protected Easing easing;
+  protected JsObjectArray<Fx> effects = JsObjectArray.create();
+  protected Function[] funcs;
+  protected Properties prps;
 
   private Effects g;
 
-  private Properties prps;
-
-  public PropertiesAnimation(Easing easing, Element elem, Properties p,
-      Function... funcs) {
-    this.easing = easing;
+  public PropertiesAnimation(Easing easing, Element elem, Properties p, Function... funcs) {
+    this.easing = easing != null ? easing : EasingCurve.linear;
     this.e = elem;
     this.funcs = funcs;
     this.prps = p;
-    g = Effects.$(e).as(Effects.Effects);
+    g = $(e).as(Effects.Effects);
   }
 
   @Override
@@ -346,11 +346,7 @@ public class PropertiesAnimation extends GQAnimation {
 
   @Override
   protected double interpolate(double progress) {
-    if (easing != null) {
-      return easing.interpolate(progress);
-    }
-    // maybe return super.interpolate() instead ?
-    return progress;
+    return easing.interpolate(progress);
   }
 
 }
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java
index b4cb8f2c..9a290753 100644
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java
@@ -45,10 +45,10 @@ import com.google.gwt.user.client.DOM;
      .promise().done(new Function(){public void f() {
         g1.transition("{x: +100}", 2000, "linear", 0);
      }});
-     
+
     $("#bar")
      .transition("{ opacity: 0.1, scale: 2, x: 50, y: 50 }", 5000, EasingCurve.easeInBack)
-     .transition("{x: +100, width: +40px}", 2000, EasingCurve.easeOut);     
+     .transition("{x: +100, width: +40px}", 2000, EasingCurve.easeOut);
 
  * </pre>
  */
@@ -156,7 +156,7 @@ public class Transitions extends GQuery {
   private static final String TRANSFORM = "_t_";
   private static final String transformOrigin = getVendorPropertyName("transformOrigin");
   
-  private static final RegExp transformRegex = RegExp.compile("^(scale|translate|rotate([XY]|3d)?|perspective|skew[XY]|x|y)$");
+  protected static final RegExp transformRegex = RegExp.compile("^(scale|translate|rotate([XY]|3d)?|perspective|skew[XY]|x|y)$");
   private static final String transition = getVendorPropertyName("transition");
   
   private static final String transitionDelay = getVendorPropertyName("transitionDelay");
@@ -270,16 +270,26 @@ public class Transitions extends GQuery {
   }
   
   /**
-   * Works like GQuery.animate(), but uses CSS transitions.
+   * The transition() method allows you to create animation effects on any numeric HTML Attribute,
+   * CSS property, or color using CSS3 transformations and transitions.
    * 
-   * It allows chaining like:
+   * It works similar to animate(), supports chainning and queueing and an extra parameter for
+   * delaying the animation.
+   *
+   * Example:
    * <pre>
-    $("#foo")
-      .transition("{ opacity: 0.1, scale: 2, x: 50, y: 50 }", 5000, EasingCurve.easeInBack)
-      .transition("{x: +100, width: +40px}", 2000, EasingCurve.easeOut);
+     $("#foo").transition("{ opacity: 0.1, scale: 2, x: 50, y: 50 }", 5000, EasingCurve.easeInBack);
+
+     $("#bar")
+       .transition("{ opacity: 0.1, scale: 2, x: 50, y: 50 }", 5000, EasingCurve.easeInBack)
+       .transition("{x: +100, width: +40px}", 2000, EasingCurve.easeOut);
    * </pre>
    */
   public Transitions transition(Object stringOrProperties, int duration, Easing easing, int delay, final Function... funcs) {
+    if (isEmpty()) {
+      return this;
+    }
+    
     final Properties p = (stringOrProperties instanceof String) ? $$((String) stringOrProperties) : (Properties) stringOrProperties;
 
     final String oldTransitions = css(transition);
@@ -295,28 +305,45 @@ public class Transitions extends GQuery {
       value += (value.isEmpty() ? "" : ", ") + s + " " + attribs;
     }
     
-    // Use gQuery queue, so as we can chain transitions
     final String transitionValue = value;
+
+    // Use gQuery queue, so as we can chain transitions, animations etc.
     delay(0, new Function(){public void f() {
-      // Configure animation using transition property
-      css(transition, transitionValue);
-      // Set all css properties for this transition 
-      css(p);
-      // prevent memory leak
-      removeData(TRANSFORM);
+      // This is called once per element
+      $(this)
+        // Configure animation using transition property
+        .css(transition, transitionValue)
+        // Set all css properties for this transition using the css method in this class 
+        .as(Transitions).css(p)
+        // prevent memory leak
+        .removeData(TRANSFORM);
     }});
     
     // restore oldTransitions in the element, and use the queue to prevent more effects being run.
     // TODO: Use transitionEnd events once GQuery supports non-bit events
     delay(duration + delay, new Function(){public void f() {
-      css(transition, oldTransitions);
-      each(funcs);
+      // This is called once per element
+      $(this).as(Transitions)
+        .css(transition, oldTransitions)
+        .each(funcs);
     }});
     
     return this;
   }
 
+  /**
+   * The transition() method allows you to create animation effects on any numeric HTML Attribute,
+   * CSS property, or color using CSS3 transformations and transitions.
+   *
+   * It works similar to animate() but has an extra parameter for delaying the animation.
+   *
+   * Example animate an element within 2 seconds:
+   * $("#foo")
+   *   .transition("{ opacity: 0.1, scale: 2, x: 50, y: 50 }", 5000, EasingCurve.easeInBack, 2000);
+   *
+   */
   public Transitions transition(Object stringOrProperties, int duration, String easing, int delay) {
     return transition(stringOrProperties, duration, EasingCurve.valueOf(easing), delay);
   }
+
 }
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java
new file mode 100755
index 00000000..3d0479ea
--- /dev/null
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java
@@ -0,0 +1,147 @@
+/*
+ * Copyright 2013, The gwtquery team.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.query.client.plugins.effects;
+
+import static com.google.gwt.query.client.GQuery.*;
+
+import com.google.gwt.dom.client.Element;
+import com.google.gwt.query.client.Function;
+import com.google.gwt.query.client.Properties;
+import com.google.gwt.query.client.js.JsObjectArray;
+import com.google.gwt.query.client.plugins.effects.Fx.TransitFx;
+import com.google.gwt.regexp.shared.MatchResult;
+
+/**
+ * Animation effects on any numeric CSS3 property or transformation
+ * using CSS3 transitions
+ */
+public class TransitionsAnimation extends PropertiesAnimation {
+  
+  public static Fx computeFxProp(Element e, String key, String val, boolean hidden) {
+    Transitions g = $(e).as(Transitions.Transitions);
+    String unit = "";
+    if ("toggle".equals(val)) {
+      val = hidden ? "show" : "hide";
+    }
+
+    if (("show".equals(val) && !hidden) || ("hide").equals(val) && hidden) {
+      return null;
+    }
+
+    if (hidden) {
+      g.show();
+    }
+
+    String cur = g.css(key, true);
+    String trsStart = cur, trsEnd = trsStart;
+    
+    if ("show".equals(val)) {
+      g.saveCssAttrs(key);
+      trsStart = "0";
+    } else if ("hide".equals(val)) {
+      if (hidden) {
+        return null;
+      }
+      g.saveCssAttrs(key);
+      trsEnd = "0";
+    } else {
+      MatchResult parts = REGEX_SYMBOL_NUMBER_UNIT.exec(val);
+      if (parts != null) {
+        unit = REGEX_NON_PIXEL_ATTRS.test(key) || Transitions.transformRegex.test(key) ? "" : "px";
+        
+        String $1 = parts.getGroup(1);
+        String $2 = parts.getGroup(2);
+        String $3 = parts.getGroup(3);
+        trsEnd = "" + Double.parseDouble($2);
+        
+        if (unit.isEmpty() && $3 != null) {
+          unit = $3;
+        }
+        if (trsStart.isEmpty()) {
+          trsStart = "0";
+        }
+        
+        if (!trsStart.endsWith(unit)) {
+          trsStart += unit;
+        }
+
+        if ($1 != null && !$1.isEmpty()) {
+          double n = "-=".equals($1) ? -1 : 1;
+          double st = Double.parseDouble(trsStart);
+          double en = Double.parseDouble(trsEnd);
+          trsEnd = "" + (st + (n*en));
+        }
+      } else {
+        trsStart = trsEnd = val;
+      }
+    }
+    return new TransitFx(key, val, trsStart, trsEnd, unit);
+  }
+
+  private Transitions g;
+
+  public TransitionsAnimation(Easing easing, Element elem, Properties p, Function... funcs) {
+    super(easing, elem, p, funcs);
+    g = $(e).as(Transitions.Transitions);
+  }
+
+  private Properties getFxProperties(boolean isStart) {
+    Properties p = $$();
+    for (int i = 0; i < effects.length(); i++) {
+      TransitFx fx = (TransitFx)effects.get(i);
+      p.set(fx.cssprop, (isStart ? fx.transitStart : fx.transitEnd) + fx.unit);
+    }
+    return p;
+  }
+
+  @Override
+  public void onStart() {
+    effects = JsObjectArray.create();
+    boolean resize = false;
+    boolean move = false;
+    boolean hidden = !g.isVisible();
+    Fx fx;
+    for (String key : prps.keys()) {
+      String val = prps.getStr(key);
+      if ((fx = computeFxProp(e, key, val, hidden)) != null) {
+        effects.add(fx);
+        resize = resize || "height".equals(key) || "width".equals(key);
+        move = move || "top".equals(key) || "left".equals(key);
+      }
+      System.out.println(fx);
+    }
+    g.saveCssAttrs(ATTRS_TO_SAVE);
+    if (resize) {
+      g.css("overflow", "hidden");
+    }
+    if (move && !g.css("position", true).matches("absolute|relative|fixed")) {
+      g.css("position", "relative");
+    }
+  }
+
+  @Override
+  public void run(int duration) {
+    onStart();
+    Properties p = getFxProperties(true);
+    System.out.println(p.toJsonString());
+    g.css(p);
+    p = getFxProperties(false);
+    System.out.println(p.toJsonString());
+    g.transition(p, duration - 150, easing, 0, new Function(){public void f() {
+      onComplete();
+    }});
+  }
+}
-- 
cgit v1.2.3


From 4d172c6f178fee109476234c99e24aa0f60871ba Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 16:12:19 +0100
Subject: Some styling corrections, println and javadoc

---
 .../query/client/plugins/effects/ClipAnimation.java |  8 ++++++--
 .../google/gwt/query/client/plugins/effects/Fx.java |  2 +-
 .../query/client/plugins/effects/Transitions.java   |  1 -
 .../plugins/effects/TransitionsAnimation.java       | 21 +++++++++------------
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
index b38e4747..a694e509 100755
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
@@ -131,8 +131,12 @@ public class ClipAnimation extends PropertiesAnimation {
     if (action == Action.HIDE) {
       progress = (1 - progress);
     }
-    int w = g.outerWidth(), h = g.outerHeight();
-    int top = 0, left = 0, right = w, bottom = h;
+    int w = g.outerWidth();
+    int h = g.outerHeight();
+    int top = 0;
+    int left = 0;
+    int right = w;
+    int bottom = h;
 
     if (direction == Direction.VERTICAL || direction == Direction.BIDIRECTIONAL) {
       bottom = (int) (h * progress);
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
index 426c408d..a2a374b8 100644
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Fx.java
@@ -19,7 +19,7 @@ public class Fx {
   public static boolean off = false;
 
   /**
-   * A pojo to store color transition values.
+   * A pojo to store css3 transition values.
    */
   public static class TransitFx extends Fx {
     public String transitEnd;
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java
index 9a290753..4d195e21 100644
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/Transitions.java
@@ -345,5 +345,4 @@ public class Transitions extends GQuery {
   public Transitions transition(Object stringOrProperties, int duration, String easing, int delay) {
     return transition(stringOrProperties, duration, EasingCurve.valueOf(easing), delay);
   }
-
 }
diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java
index 3d0479ea..d15f19ec 100755
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/TransitionsAnimation.java
@@ -37,7 +37,7 @@ public class TransitionsAnimation extends PropertiesAnimation {
       val = hidden ? "show" : "hide";
     }
 
-    if (("show".equals(val) && !hidden) || ("hide").equals(val) && hidden) {
+    if ("show".equals(val) && !hidden || "hide".equals(val) && hidden) {
       return null;
     }
 
@@ -62,13 +62,13 @@ public class TransitionsAnimation extends PropertiesAnimation {
       if (parts != null) {
         unit = REGEX_NON_PIXEL_ATTRS.test(key) || Transitions.transformRegex.test(key) ? "" : "px";
         
-        String $1 = parts.getGroup(1);
-        String $2 = parts.getGroup(2);
-        String $3 = parts.getGroup(3);
-        trsEnd = "" + Double.parseDouble($2);
+        String part1 = parts.getGroup(1);
+        String part2 = parts.getGroup(2);
+        String part3 = parts.getGroup(3);
+        trsEnd = "" + Double.parseDouble(part2);
         
-        if (unit.isEmpty() && $3 != null) {
-          unit = $3;
+        if (unit.isEmpty() && part3 != null) {
+          unit = part3;
         }
         if (trsStart.isEmpty()) {
           trsStart = "0";
@@ -78,8 +78,8 @@ public class TransitionsAnimation extends PropertiesAnimation {
           trsStart += unit;
         }
 
-        if ($1 != null && !$1.isEmpty()) {
-          double n = "-=".equals($1) ? -1 : 1;
+        if (part1 != null && !part1.isEmpty()) {
+          double n = "-=".equals(part1) ? -1 : 1;
           double st = Double.parseDouble(trsStart);
           double en = Double.parseDouble(trsEnd);
           trsEnd = "" + (st + (n*en));
@@ -121,7 +121,6 @@ public class TransitionsAnimation extends PropertiesAnimation {
         resize = resize || "height".equals(key) || "width".equals(key);
         move = move || "top".equals(key) || "left".equals(key);
       }
-      System.out.println(fx);
     }
     g.saveCssAttrs(ATTRS_TO_SAVE);
     if (resize) {
@@ -136,10 +135,8 @@ public class TransitionsAnimation extends PropertiesAnimation {
   public void run(int duration) {
     onStart();
     Properties p = getFxProperties(true);
-    System.out.println(p.toJsonString());
     g.css(p);
     p = getFxProperties(false);
-    System.out.println(p.toJsonString());
     g.transition(p, duration - 150, easing, 0, new Function(){public void f() {
       onComplete();
     }});
-- 
cgit v1.2.3


From 3a7de94854e942da671e0e28b769a9dfdf34f68c Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 16:24:18 +0100
Subject: Fixing test so as they run with java 1.6

---
 .../src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java b/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java
index d6d824c2..76ed554f 100644
--- a/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java
+++ b/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java
@@ -1571,14 +1571,14 @@ public class GQueryCoreTestGwt extends GWTTestCase {
                .data("string", "foo")
                .data("object", o);
 
-    double d = g.data("number");
+    Double d = g.data("number");
     assertEquals(3.5d, d);
     int i = g.data("number", Integer.class);
     assertEquals(3, i);
     long l = g.data("number", Long.class);
     assertEquals(3l, l);
 
-    boolean b = g.data("bool");
+    Boolean b = g.data("bool");
     assertTrue(b);
 
     String s = g.data("string");
-- 
cgit v1.2.3


From 506ddeaaddc64b4b92f8ed482d3e4695743b8d31 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 16:25:41 +0100
Subject: remove import

---
 .../src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java b/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java
index 76ed554f..416d142e 100644
--- a/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java
+++ b/gwtquery-core/src/test/java/com/google/gwt/query/client/GQueryCoreTestGwt.java
@@ -50,8 +50,6 @@ import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 
-import javax.validation.constraints.AssertFalse;
-
 import static com.google.gwt.query.client.GQuery.$;
 import static com.google.gwt.query.client.GQuery.$$;
 import static com.google.gwt.query.client.GQuery.document;
-- 
cgit v1.2.3


From 5deaf203c8dfaf3dc04fe5c1ab91f6a30a72e4af Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 16:33:40 +0100
Subject: set source/target java to java-6

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 55d8ff6a..0a371f9c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -80,7 +80,7 @@
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-pmd-plugin</artifactId>
               <configuration>
-                <targetJdk>1.5</targetJdk>
+                <targetJdk>1.6</targetJdk>
               </configuration>
             </plugin>
           </plugins>
@@ -97,8 +97,8 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
-                    <source>1.5</source>
-                    <target>1.5</target>
+                    <source>1.6</source>
+                    <target>1.6</target>
                 </configuration>
             </plugin>
         </plugins>
-- 
cgit v1.2.3


From aa84f6dbdf6399aeaa6f34b7ea6dc114e60dbaeb Mon Sep 17 00:00:00 2001
From: Manuel Carrasco Moñino <manuel.carrasco.m@gmail.com>
Date: Sat, 9 Nov 2013 16:42:07 +0100
Subject: split long line

---
 .../com/google/gwt/query/client/plugins/effects/ClipAnimation.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
index a694e509..2285230c 100755
--- a/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
+++ b/gwtquery-core/src/main/java/com/google/gwt/query/client/plugins/effects/ClipAnimation.java
@@ -59,7 +59,8 @@ public class ClipAnimation extends PropertiesAnimation {
   private Function[] funcs;
   private Effects g;
 
-  public ClipAnimation(Element elem, Action a, Corner c, Direction d, Easing easing,  Properties p, final Function... funcs) {
+  public ClipAnimation(Element elem, Action a, Corner c, Direction d, Easing easing,
+      Properties p, final Function... funcs) {
     super(easing, elem, p, funcs);
     if (a == Action.TOGGLE) {
       a = GQuery.$(elem).isVisible() ? Action.HIDE : Action.SHOW;
-- 
cgit v1.2.3