aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Pursehouse <david.pursehouse@gmail.com>2020-01-24 16:49:14 +0900
committerDavid Pursehouse <david.pursehouse@gmail.com>2020-01-24 16:49:14 +0900
commit8fa3594565d43c81d5e1a34660b29a861b81d43a (patch)
tree55c04368e7d6ca69959bcfcf71e324daeb78aeac
parentfc7b0031631b7af01f44b5d36b7f9f0fab23bf9f (diff)
downloadjgit-8fa3594565d43c81d5e1a34660b29a861b81d43a.tar.gz
jgit-8fa3594565d43c81d5e1a34660b29a861b81d43a.zip
Remove Error-Prone ExpectedExceptionChecker
The checker only checks for misuse of ExpectedException. Since we've moved to JUnit 4.13 and assertThrows, ExpectedException won't be used at all, so now we can get rid of that setting. Change-Id: Ia9189936ae215110f1f5fc6459c5dbc944404ade Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
-rw-r--r--org.eclipse.jgit.benchmarks/pom.xml3
-rw-r--r--pom.xml3
-rw-r--r--tools/BUILD1
3 files changed, 0 insertions, 7 deletions
diff --git a/org.eclipse.jgit.benchmarks/pom.xml b/org.eclipse.jgit.benchmarks/pom.xml
index 426fb7ffe4..5e707719ec 100644
--- a/org.eclipse.jgit.benchmarks/pom.xml
+++ b/org.eclipse.jgit.benchmarks/pom.xml
@@ -69,9 +69,6 @@
<configuration>
<compilerId>javac-with-errorprone</compilerId>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
- <compilerArgs>
- <arg>-Xep:ExpectedExceptionChecker:ERROR</arg>
- </compilerArgs>
</configuration>
</execution>
</executions>
diff --git a/pom.xml b/pom.xml
index 0e1e98fa60..06e2f308a0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -836,9 +836,6 @@
<configuration>
<compilerId>javac-with-errorprone</compilerId>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
- <compilerArgs>
- <arg>-Xep:ExpectedExceptionChecker:ERROR</arg>
- </compilerArgs>
<excludes>
<exclude>org/eclipse/jgit/transport/InsecureCipherFactory.java</exclude>
</excludes>
diff --git a/tools/BUILD b/tools/BUILD
index e5931dc8cd..d66837700c 100644
--- a/tools/BUILD
+++ b/tools/BUILD
@@ -39,7 +39,6 @@ java_package_configuration(
"-Xep:ElementsCountedInLoop:ERROR",
"-Xep:EqualsHashCode:ERROR",
"-Xep:EqualsIncompatibleType:ERROR",
- "-Xep:ExpectedExceptionChecker:ERROR",
"-Xep:Finally:WARN",
"-Xep:FloatingPointLiteralPrecision:ERROR",
"-Xep:FragmentInjection:ERROR",