summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIvan Frade <ifrade@google.com>2023-11-09 14:45:32 -0800
committerIvan Frade <ifrade@google.com>2023-11-10 08:33:00 -0800
commitfcea1fe496a6b4d29285d731ae71b3b7a01ad13f (patch)
tree528a3e1e57cbbf51ae1c283c70d02a5fbbd2059c
parent1b28c2d0018b06ee54de2d1237b5d42d98160706 (diff)
downloadjgit-fcea1fe496a6b4d29285d731ae71b3b7a01ad13f.tar.gz
jgit-fcea1fe496a6b4d29285d731ae71b3b7a01ad13f.zip
CommitGraphWriter: Remove unnecesary progress update call
Change [1] reduced the scope of the "writing commit graph" monitoring task. This left some monitor#update() calls out of any task. When out of a task, the #update call is a noop. Delete this update calls as they are noops and misleading. The affected chunks are usually small and quick to write, so probably they don't need progress monitoring. [1] https://git.eclipse.org/r/c/jgit/jgit/+/205339 Change-Id: I74d94e6e44e58816937dc8a84e5a10b340e54e0b
-rw-r--r--org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java3
1 files changed, 0 insertions, 3 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java
index b697edb60e..1f1c35ac19 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java
@@ -261,7 +261,6 @@ public class CommitGraphWriter {
for (int n : fanout) {
NB.encodeInt32(tmp, 0, n);
out.write(tmp, 0, 4);
- out.getWriteMonitor().update(1);
}
}
@@ -272,7 +271,6 @@ public class CommitGraphWriter {
for (RevCommit c : graphCommits) {
c.copyRawTo(tmp, 0);
out.write(tmp, 0, hashsz);
- out.getWriteMonitor().update(1);
}
}
@@ -470,7 +468,6 @@ public class CommitGraphWriter {
}
NB.encodeInt32(tmp, 0, edgeValue);
out.write(tmp);
- out.getWriteMonitor().update(1);
}
}
}