diff options
author | Han-Wen Nienhuys <hanwen@google.com> | 2022-08-18 18:10:47 +0200 |
---|---|---|
committer | Han-Wen NIenhuys <hanwen@google.com> | 2022-08-23 04:24:37 -0400 |
commit | ddb1a0c3a27c9a226601a7d909dcbca0c7a9da18 (patch) | |
tree | 99031d1706eab893b070de5c3ca134803b11cfe9 | |
parent | d718127a7ec756015561def88271e5e253fcb84b (diff) | |
download | jgit-ddb1a0c3a27c9a226601a7d909dcbca0c7a9da18.tar.gz jgit-ddb1a0c3a27c9a226601a7d909dcbca0c7a9da18.zip |
WorkTreeUpdater#Result: hide data members
This is the standard across JGit.
Change-Id: Ie52ad7000d8725657b33dd4f3adcc05ab9666875
-rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java | 8 | ||||
-rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/util/WorkTreeUpdater.java | 25 |
2 files changed, 23 insertions, 10 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java b/org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java index ab82dd0c30..d79f5d4100 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java @@ -1181,12 +1181,12 @@ public class ResolveMerger extends ThreeWayMerger { workTreeUpdater.writeWorkTreeChanges(true); if (getUnmergedPaths().isEmpty() && !failed()) { WorkTreeUpdater.Result result = workTreeUpdater.writeIndexChanges(); - resultTree = result.treeId; - modifiedFiles = result.modifiedFiles; - for (String f : result.failedToDelete) { + resultTree = result.getTreeId(); + modifiedFiles = result.getModifiedFiles(); + for (String f : result.getFailedToDelete()) { failingPaths.put(f, MergeFailureReason.COULD_NOT_DELETE); } - return result.failedToDelete.isEmpty(); + return result.getFailedToDelete().isEmpty(); } resultTree = null; return false; diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/util/WorkTreeUpdater.java b/org.eclipse.jgit/src/org/eclipse/jgit/util/WorkTreeUpdater.java index 98eaf931b8..a9f56c2ac9 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/util/WorkTreeUpdater.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/util/WorkTreeUpdater.java @@ -74,20 +74,33 @@ public class WorkTreeUpdater implements Closeable { */ public static class Result { + private final List<String> modifiedFiles = new LinkedList<>(); + + + private final List<String> failedToDelete = new LinkedList<>(); + + private ObjectId treeId = null; + /** - * Files modified during this operation. + * @return Modified tree ID if any, or null otherwise. */ - public List<String> modifiedFiles = new LinkedList<>(); + public ObjectId getTreeId() { + return treeId; + } /** - * Files in this list were failed to be deleted. + * @return Files that couldn't be deleted. */ - public List<String> failedToDelete = new LinkedList<>(); + public List<String> getFailedToDelete() { + return failedToDelete; + } /** - * Modified tree ID if any, or null otherwise. + * @return Files modified during this operation. */ - public ObjectId treeId = null; + public List<String> getModifiedFiles() { + return modifiedFiles; + } } Result result = new Result(); |