summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonathan Nieder <jrn@google.com>2018-11-20 16:18:44 -0800
committerJonathan Nieder <jrn@google.com>2018-11-20 16:18:44 -0800
commit647cc8f6040cbcdeb6ca87f68ff70734357783c8 (patch)
tree005cc46f81b858ae9e1e5daffaaa0a6ca194f584
parente751c878b04a6d4d341fb8f9492783a70e1ebe86 (diff)
downloadjgit-647cc8f6040cbcdeb6ca87f68ff70734357783c8.tar.gz
jgit-647cc8f6040cbcdeb6ca87f68ff70734357783c8.zip
Remove unnecessary modifiers from interfaces
This continues what commit d9ac7ddf1026123fee6c4477d172d614522dfc08 (Remove unnecessary modifiers from interfaces, 2018-11-15) started. Change-Id: I89720985a5a986722a0dcb9b5e9bbc25996bd5b3
-rw-r--r--org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ServletBinder.java4
-rw-r--r--org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LargeFileRepository.java8
-rw-r--r--org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/auth/AuthenticationHandler.java2
-rw-r--r--org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/transport/sshd/KeyCache.java2
-rw-r--r--org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java10
-rw-r--r--org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java12
6 files changed, 19 insertions, 19 deletions
diff --git a/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ServletBinder.java b/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ServletBinder.java
index b2b4748989..2a03633580 100644
--- a/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ServletBinder.java
+++ b/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ServletBinder.java
@@ -57,7 +57,7 @@ public interface ServletBinder {
* the filter to trigger while processing the path.
* @return {@code this}.
*/
- public ServletBinder through(Filter filter);
+ ServletBinder through(Filter filter);
/**
* Set the servlet to execute on this path
@@ -65,5 +65,5 @@ public interface ServletBinder {
* @param servlet
* the servlet to execute on this path.
*/
- public void with(HttpServlet servlet);
+ void with(HttpServlet servlet);
}
diff --git a/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LargeFileRepository.java b/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LargeFileRepository.java
index 4cb0277b64..c2439adf62 100644
--- a/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LargeFileRepository.java
+++ b/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LargeFileRepository.java
@@ -61,7 +61,7 @@ public interface LargeFileRepository {
* id of the object to download
* @return Action for downloading the object
*/
- public Response.Action getDownloadAction(AnyLongObjectId id);
+ Response.Action getDownloadAction(AnyLongObjectId id);
/**
* Get upload action
@@ -72,7 +72,7 @@ public interface LargeFileRepository {
* size of the object to be uploaded
* @return Action for uploading the object
*/
- public Response.Action getUploadAction(AnyLongObjectId id, long size);
+ Response.Action getUploadAction(AnyLongObjectId id, long size);
/**
* Get verify action
@@ -83,7 +83,7 @@ public interface LargeFileRepository {
* doesn't support or require verification
*/
@Nullable
- public Response.Action getVerifyAction(AnyLongObjectId id);
+ Response.Action getVerifyAction(AnyLongObjectId id);
/**
* Get size of an object
@@ -94,5 +94,5 @@ public interface LargeFileRepository {
* exist
* @throws java.io.IOException
*/
- public long getSize(AnyLongObjectId id) throws IOException;
+ long getSize(AnyLongObjectId id) throws IOException;
}
diff --git a/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/auth/AuthenticationHandler.java b/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/auth/AuthenticationHandler.java
index 34724687a2..0e98a2e17a 100644
--- a/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/auth/AuthenticationHandler.java
+++ b/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/auth/AuthenticationHandler.java
@@ -117,5 +117,5 @@ public interface AuthenticationHandler<ParameterType, TokenType>
boolean isDone();
@Override
- public void close();
+ void close();
}
diff --git a/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/transport/sshd/KeyCache.java b/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/transport/sshd/KeyCache.java
index d1865d9f73..d8c1d30426 100644
--- a/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/transport/sshd/KeyCache.java
+++ b/org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/transport/sshd/KeyCache.java
@@ -70,5 +70,5 @@ public interface KeyCache {
* Removes all {@link KeyPair} from this cache and destroys their private
* keys. This cache instance must not be used anymore thereafter.
*/
- public void close();
+ void close();
}
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java
index 9b98250884..d5e17224cf 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/ReadableChannel.java
@@ -57,7 +57,7 @@ public interface ReadableChannel extends ReadableByteChannel {
* @throws java.io.IOException
* the channel's current position cannot be obtained.
*/
- public long position() throws IOException;
+ long position() throws IOException;
/**
* Seek the current position of the channel to a new offset.
@@ -70,7 +70,7 @@ public interface ReadableChannel extends ReadableByteChannel {
* channel only supports block aligned IO and the current
* position is not block aligned.
*/
- public void position(long newPosition) throws IOException;
+ void position(long newPosition) throws IOException;
/**
* Get the total size of the channel.
@@ -83,7 +83,7 @@ public interface ReadableChannel extends ReadableByteChannel {
* @throws java.io.IOException
* the size cannot be determined.
*/
- public long size() throws IOException;
+ long size() throws IOException;
/**
* Get the recommended alignment for reads.
@@ -102,7 +102,7 @@ public interface ReadableChannel extends ReadableByteChannel {
* @return recommended alignment size for randomly positioned reads. Does
* not need to be a power of 2.
*/
- public int blockSize();
+ int blockSize();
/**
* Recommend the channel maintain a read-ahead buffer.
@@ -131,5 +131,5 @@ public interface ReadableChannel extends ReadableByteChannel {
* @throws java.io.IOException
* if the read ahead cannot be adjusted.
*/
- public void setReadAheadBytes(int bufferSize) throws IOException;
+ void setReadAheadBytes(int bufferSize) throws IOException;
}
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java
index f759e23ef4..2c806235a6 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/ObjectReuseAsIs.java
@@ -79,7 +79,7 @@ public interface ObjectReuseAsIs {
* the Git type of the object that will be packed.
* @return a new instance for this object.
*/
- public ObjectToPack newObjectToPack(AnyObjectId objectId, int type);
+ ObjectToPack newObjectToPack(AnyObjectId objectId, int type);
/**
* Select the best object representation for a packer.
@@ -114,7 +114,7 @@ public interface ObjectReuseAsIs {
* @throws java.io.IOException
* the repository cannot be accessed. Packing will abort.
*/
- public void selectObjectRepresentation(PackWriter packer,
+ void selectObjectRepresentation(PackWriter packer,
ProgressMonitor monitor, Iterable<ObjectToPack> objects)
throws IOException, MissingObjectException;
@@ -155,7 +155,7 @@ public interface ObjectReuseAsIs {
* the stream cannot be written to, or one or more required
* objects cannot be accessed from the object database.
*/
- public void writeObjects(PackOutputStream out, List<ObjectToPack> list)
+ void writeObjects(PackOutputStream out, List<ObjectToPack> list)
throws IOException;
/**
@@ -200,7 +200,7 @@ public interface ObjectReuseAsIs {
* the stream's write method threw an exception. Packing will
* abort.
*/
- public void copyObjectAsIs(PackOutputStream out, ObjectToPack otp,
+ void copyObjectAsIs(PackOutputStream out, ObjectToPack otp,
boolean validate) throws IOException,
StoredObjectRepresentationNotAvailableException;
@@ -216,7 +216,7 @@ public interface ObjectReuseAsIs {
* @throws java.io.IOException
* the pack cannot be read, or stream did not accept a write.
*/
- public abstract void copyPackAsIs(PackOutputStream out, CachedPack pack)
+ void copyPackAsIs(PackOutputStream out, CachedPack pack)
throws IOException;
/**
@@ -234,6 +234,6 @@ public interface ObjectReuseAsIs {
* Callers may choose to ignore this and continue as-if there
* were no cached packs.
*/
- public Collection<CachedPack> getCachedPacksAndUpdate(
+ Collection<CachedPack> getCachedPacksAndUpdate(
BitmapBuilder needBitmap) throws IOException;
}