Declare essentially static methods as static

Change-Id: I83ca25fb569c0dbc36eb374d5437fcf2b65a6f68

4 files changed, 11 insertions, 11 deletions

diff --git a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IPZillaQuery.java b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IPZillaQuery.java
index b8db84a89c..23fdf68a89 100644
--- a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IPZillaQuery.java
+++ b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IPZillaQuery.java
@@ -156,7 +156,7 @@ class IPZillaQuery {
 		}
 	}
 
-	private BufferedReader reader(HttpURLConnection conn)
+	private static BufferedReader reader(HttpURLConnection conn)
 			throws UnsupportedEncodingException, IOException {
 		String encoding = conn.getContentEncoding();
 		InputStream in = conn.getInputStream();
@@ -206,7 +206,7 @@ class IPZillaQuery {
 		}
 	}
 
-	private String readFully(HttpURLConnection c) throws IOException {
+	private static String readFully(HttpURLConnection c) throws IOException {
 		String enc = c.getContentEncoding();
 		Reader reader;
 		if (enc != null) {
@@ -240,7 +240,7 @@ class IPZillaQuery {
 		return c;
 	}
 
-	private void setCookie(URL url, String name, String value)
+	private static void setCookie(URL url, String name, String value)
 			throws IOException {
 		Map<String, List<String>> cols = new HashMap<String, List<String>>();
 		cols.put("Set-Cookie", Collections.singletonList(name + "=" + value));
@@ -253,7 +253,7 @@ class IPZillaQuery {
 		}
 	}
 
-	private CQ parseOneCQ(Map<String, String> row) {
+	private static CQ parseOneCQ(Map<String, String> row) {
 		long id = Long.parseLong(row.get("bug_id"));
 		String state = row.get("bug_severity");
 		String bug_status = row.get("bug_status");
diff --git a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java
index 06d5393ca7..eea8a688ef 100644
--- a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java
+++ b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java
@@ -273,7 +273,7 @@ public class IpLogGenerator {
 		}
 	}
 
-	private Date parseDate(SimpleDateFormat dt, String value)
+	private static Date parseDate(SimpleDateFormat dt, String value)
 			throws IOException {
 		if ("NULL".equals(value) || "".equals(value) || value == null)
 			return null;
@@ -524,7 +524,7 @@ public class IpLogGenerator {
 		return project;
 	}
 
-	private void populateProjectType(Project p, Element project) {
+	private static void populateProjectType(Project p, Element project) {
 		required(project, "id", p.getID());
 		required(project, "name", p.getName());
 		optional(project, "comments", p.getComments());
@@ -557,7 +557,7 @@ public class IpLogGenerator {
 		return r;
 	}
 
-	private String mapCQState(String state) {
+	private static String mapCQState(String state) {
 		// "approved" CQs shall be listed as "active" in the iplog
 		if (state.equals("approved"))
 			return "active";
@@ -602,13 +602,13 @@ public class IpLogGenerator {
 		return doc.createElementNS(IPLOG_NS, IPLOG_PFX + name);
 	}
 
-	private void required(Element r, String name, String value) {
+	private static void required(Element r, String name, String value) {
 		if (value == null)
 			value = "";
 		r.setAttribute(name, value);
 	}
 
-	private void optional(Element r, String name, String value) {
+	private static void optional(Element r, String name, String value) {
 		if (value != null && value.length() > 0)
 			r.setAttribute(name, value);
 	}
diff --git a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogMeta.java b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogMeta.java
index ba10f6f24e..c491d67cc9 100644
--- a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogMeta.java
+++ b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogMeta.java
@@ -142,7 +142,7 @@ public class IpLogMeta {
 		reviewUrl = cfg.getString(S_REVIEW, null, K_URL);
 	}
 
-	private List<Project> parseProjects(final Config cfg,
+	private static List<Project> parseProjects(final Config cfg,
 			final String sectionName) {
 		final List<Project> dst = new ArrayList<Project>();
 		for (String id : cfg.getSubsections(sectionName)) {
diff --git a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/SimpleCookieManager.java b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/SimpleCookieManager.java
index dca6f15054..d6b3a36980 100644
--- a/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/SimpleCookieManager.java
+++ b/org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/SimpleCookieManager.java
@@ -112,7 +112,7 @@ public class SimpleCookieManager extends CookieHandler {
 		}
 	}
 
-	private String hostOf(URI uri) {
+	private static String hostOf(URI uri) {
 		StringBuilder key = new StringBuilder();
 		key.append(uri.getScheme());
 		key.append(':');