summaryrefslogtreecommitdiffstats
path: root/org.eclipse.jgit.junit.http
diff options
context:
space:
mode:
authorShawn Pearce <spearce@spearce.org>2017-01-20 08:41:29 -0800
committerMatthias Sohn <matthias.sohn@sap.com>2017-01-21 09:44:14 +0100
commit131b09106f76cdfca1d7292f2cc39a35834c7a67 (patch)
treeb5a5596015704078f456e6ba8bc00f17873b0641 /org.eclipse.jgit.junit.http
parentf503a9f5b7812103644367109f1211470d61b383 (diff)
downloadjgit-131b09106f76cdfca1d7292f2cc39a35834c7a67.tar.gz
jgit-131b09106f76cdfca1d7292f2cc39a35834c7a67.zip
Change StreamGobbler to Runnable to avoid unused Future
It can be considered a programming error to create a Future<T> but do nothing with that object. There is an async computation happening and without holding and checking the Future for done or exception the caller has no idea if it has completed. FS doesn't really care about these StreamGobblers finishing. Instead use Runnable with execute(Runnable), which doesn't return a Future. Change-Id: I93b66d1f6c869e66be5c1169d8edafe781e601f6
Diffstat (limited to 'org.eclipse.jgit.junit.http')
0 files changed, 0 insertions, 0 deletions