diff options
| author | Jonathan Nieder <jrn@google.com> | 2018-10-09 15:56:55 -0700 |
|---|---|---|
| committer | Jonathan Nieder <jrn@google.com> | 2018-10-09 15:56:55 -0700 |
| commit | b0991ca80530bc6f73fd92ad5e183f434d26da1a (patch) | |
| tree | 24461699e0b33d4447325a71c994e74cb91a4062 /org.eclipse.jgit.lfs | |
| parent | 608b6b03b1182329ae6f76a4c3938874dcc9c210 (diff) | |
| download | jgit-b0991ca80530bc6f73fd92ad5e183f434d26da1a.tar.gz jgit-b0991ca80530bc6f73fd92ad5e183f434d26da1a.zip | |
Format @NonNull on return value as method annotation
For example, instead of using
public @NonNull String getMyFavoriteString() { ... }
use
@NonNull
public String getMyFavoriteString() { ... }
This makes the style more consistent (the existing JGit code base
tends to lean toward the second style) and makes the source code
better reflect how the annotation is parsed, as a METHOD annotation.
Longer term, we should switch to a TYPE_USE annotation and switch to
the first style.
Noticed using a style checker that follows
https://google.github.io/styleguide/javaguide.html#s4.8.5-annotations
Change-Id: I9b9fa08035d805ca660520f812a84d2f47eff507
Reported-by: Ivan Frade <ifrade@google.com>
Signed-off-by: Jonathan Nieder <jrn@google.com>
Diffstat (limited to 'org.eclipse.jgit.lfs')
| -rw-r--r-- | org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java b/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java index 955eca0c3f..feb8b4ae5a 100644 --- a/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java +++ b/org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java @@ -227,7 +227,8 @@ public class LfsConnectionFactory { * @throws IOException * in case of any error. */ - public static @NonNull HttpConnection getLfsContentConnection( + @NonNull + public static HttpConnection getLfsContentConnection( Repository repo, Protocol.Action action, String method) throws IOException { URL contentUrl = new URL(action.href); |