diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2012-03-15 07:57:56 -0700 |
|---|---|---|
| committer | Chris Aniszczyk <zx@twitter.com> | 2012-03-18 08:20:06 -0500 |
| commit | 04ab2dac3728f8e43dc42a9e700819dd2e7a4a93 (patch) | |
| tree | 02870fcaea37f90d6d1a832dfc1eb822638a143c /org.eclipse.jgit.pgm.test/build.properties | |
| parent | c75aa1aed238dd62d6f00958a5fb2cf782349ee1 (diff) | |
| download | jgit-04ab2dac3728f8e43dc42a9e700819dd2e7a4a93.tar.gz jgit-04ab2dac3728f8e43dc42a9e700819dd2e7a4a93.zip | |
Clarify the purpose of ObjectInserter.buffer()
Recently Robin tried to increase the size of the buffer used by
ObjectInserter to fix a bug in the InputStream that handles AutoCRLF.
The purpose of this buffer is NOT to make a random InputStream work
correctly by passing it a larger buffer during read(byte[],int,int).
Clarify the Javadoc on the buffer() method to reduce the risk
someone tries to abuse it again.
While we are here, modify the method to load the field into a local
variable before returning. This should cut down 1 field load during
the common case of the buffer being already allocated.
Change-Id: Ic6898530d10fcd7e59f90397117a4a0d97e1f031
Signed-off-by: Chris Aniszczyk <zx@twitter.com>
Diffstat (limited to 'org.eclipse.jgit.pgm.test/build.properties')
0 files changed, 0 insertions, 0 deletions