diff options
| author | Matthias Sohn <matthias.sohn@sap.com> | 2019-05-05 03:18:23 +0200 |
|---|---|---|
| committer | Matthias Sohn <matthias.sohn@sap.com> | 2019-05-22 08:13:22 +0200 |
| commit | b513b7747713a505e19e237ac2e7f8d9c699bc4d (patch) | |
| tree | 9664e6d59d3c5f185c9257ae218fd8ed1ef49eb7 /org.eclipse.jgit/.settings | |
| parent | 201bbd6eadabef7f386fa936a505b9312519ab4e (diff) | |
| download | jgit-b513b7747713a505e19e237ac2e7f8d9c699bc4d.tar.gz jgit-b513b7747713a505e19e237ac2e7f8d9c699bc4d.zip | |
Measure file timestamp resolution used in FileSnapshot
FileSnapshot.notRacyClean() assumed a worst case filesystem timestamp
resolution of 2.5 sec (FAT has a resolution of 2 sec). Instead measure
timestamp resolution to avoid unnecessary IO caused by false positives
in detecting the racy git problem caused by finite filesystem timestamp
resolution [1].
Cache the measured resolution per FileStore since timestamp resolution
depends on the respective filesystem type. If timestamp resolution
cannot be measured or fails due to an exception fallback to the worst
case FAT timestamp resolution and avoid caching this value.
Add a 10% safety margin in FileSnapshot.notRacyClean(), though running
FsTest.testFsTimestampResolution() 1000 times which is not using a
safety margin didn't fail on Mac using APFS and Java 8, 11, 12.
Measured Java file timestamp resolution: [2]
[1] https://github.com/git/git/blob/master/Documentation/technical/racy-git.txt
[2] https://docs.google.com/spreadsheets/d/1imy0y6WmRqBf0kjCxzxj2X7M50eIVfa7oaUIzEOHmjo
Bug: 546891
Change-Id: I493f3b57b6b306285ffa7d392339d253e5966ab8
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Diffstat (limited to 'org.eclipse.jgit/.settings')
| -rw-r--r-- | org.eclipse.jgit/.settings/.api_filters | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/org.eclipse.jgit/.settings/.api_filters b/org.eclipse.jgit/.settings/.api_filters index da0a3f44c4..a0fafdb1b0 100644 --- a/org.eclipse.jgit/.settings/.api_filters +++ b/org.eclipse.jgit/.settings/.api_filters @@ -59,5 +59,19 @@ <message_argument value="fileAttributes(File)"/> </message_arguments> </filter> + <filter id="1142947843"> + <message_arguments> + <message_argument value="5.2.3"/> + <message_argument value="getFsTimerResolution(Path)"/> + </message_arguments> + </filter> + </resource> + <resource path="src/org/eclipse/jgit/util/FileUtils.java" type="org.eclipse.jgit.util.FileUtils"> + <filter id="1142947843"> + <message_arguments> + <message_argument value="5.2.3"/> + <message_argument value="touch(Path)"/> + </message_arguments> + </filter> </resource> </component> |