diff options
| author | Darius Jokilehto <dariusjokilehto+os@gmail.com> | 2022-02-04 16:13:27 +0000 |
|---|---|---|
| committer | Darius Jokilehto <dariusjokilehto+os@gmail.com> | 2022-02-08 09:52:03 +0000 |
| commit | 78c9b9260a5287d09c87b407e396021590714513 (patch) | |
| tree | fc6a40d2ac048c356795cba27adb77effa2fd260 /org.eclipse.jgit/.settings | |
| parent | 2cc0009737182822a82731f523c0f6ded7601ddb (diff) | |
| download | jgit-78c9b9260a5287d09c87b407e396021590714513.tar.gz jgit-78c9b9260a5287d09c87b407e396021590714513.zip | |
Stop initCause throwing in readAdvertisedRefs
BasePackConnection::readAdvertisedRefsImpl was creating an exception by
calling `noRepository`, and then blindly calling `initCause` on it. As
`noRepository` can be overridden, it's not guaranteed to be missing a
cause.
BasePackPushConnection overrides `noRepository` and initiates a fetch,
which may throw a `NoRemoteRepositoryException` with a cause.
In this case calling `initCause` threw an `IllegalStateException`.
In order to throw the correct exception, we now return the
BasePackPushConnection exception and suppress the one thrown by
BasePackConnection
Bug: 578511
Change-Id: Ic1018b214be1e83d895979ee6c7cbce3f6765f6f
Diffstat (limited to 'org.eclipse.jgit/.settings')
| -rw-r--r-- | org.eclipse.jgit/.settings/.api_filters | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/org.eclipse.jgit/.settings/.api_filters b/org.eclipse.jgit/.settings/.api_filters index 83a83817f4..acceac05df 100644 --- a/org.eclipse.jgit/.settings/.api_filters +++ b/org.eclipse.jgit/.settings/.api_filters @@ -8,6 +8,14 @@ </message_arguments> </filter> </resource> + <resource path="src/org/eclipse/jgit/transport/BasePackPushConnection.java" type="org.eclipse.jgit.transport.BasePackPushConnection"> + <filter id="338792546"> + <message_arguments> + <message_argument value="org.eclipse.jgit.transport.BasePackPushConnection"/> + <message_argument value="noRepository()"/> + </message_arguments> + </filter> + </resource> <resource path="src/org/eclipse/jgit/transport/ProtocolV2Hook.java" type="org.eclipse.jgit.transport.ProtocolV2Hook"> <filter id="404000815"> <message_arguments> |