diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2010-11-08 15:34:47 -0800 |
|---|---|---|
| committer | Shawn O. Pearce <spearce@spearce.org> | 2010-11-08 15:34:47 -0800 |
| commit | 08a9682e3264cb3457c63696f0a13efbd6a5dfdc (patch) | |
| tree | 42c8673d61d8e2ef9fa8ab8320033b04a129e0b8 /org.eclipse.jgit/findBugs | |
| parent | 2dc2dd8b1b4c98b255b3f2dec655a3f0b197ce07 (diff) | |
| download | jgit-08a9682e3264cb3457c63696f0a13efbd6a5dfdc.tar.gz jgit-08a9682e3264cb3457c63696f0a13efbd6a5dfdc.zip | |
Revert "[findBugs] Silence DM_STRING_CTOR on PacketLineIn"
This reverts commit 1e510ec20e0391010419b17e9a9095ad54941d3c.
Instead work around the warning by defining our constant by
constructing it through a StringBuilder.
Change-Id: If139509e769d649609c62eff359ebaea5dd286b2
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
CC: Matthias Sohn <matthias.sohn@sap.com>
CC: Chris Aniszczyk <caniszczyk@gmail.com>
Diffstat (limited to 'org.eclipse.jgit/findBugs')
| -rw-r--r-- | org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml b/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml index f93c8f3027..948308e778 100644 --- a/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml +++ b/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml @@ -38,12 +38,4 @@ <Class name="org.eclipse.jgit.util.TemporaryBuffer$BlockInputStream" /> <Bug pattern="UR_UNINIT_READ" /> </Match> - - <!-- Silence invoke inefficient String constructor, we do not want to pool - here --> - <Match> - <Class name="org.eclipse.jgit.transport.PacketLineIn" /> - <Method name="<clinit>" /> - <Bug pattern="DM_STRING_CTOR" /> - </Match> </FindBugsFilter> |