diff options
| author | David Pursehouse <david.pursehouse@gmail.com> | 2019-06-12 13:12:52 +0900 |
|---|---|---|
| committer | Matthias Sohn <matthias.sohn@sap.com> | 2019-06-15 21:55:39 +0200 |
| commit | 2eeabde94a4a39dd827d4ecc8110a6137d401cba (patch) | |
| tree | 088bcbb397f45ca988b9e49ce49f75380595297c /org.eclipse.jgit/src | |
| parent | 858736df37dd9d1b60f6173efae791912dd14d67 (diff) | |
| download | jgit-2eeabde94a4a39dd827d4ecc8110a6137d401cba.tar.gz jgit-2eeabde94a4a39dd827d4ecc8110a6137d401cba.zip | |
BasePackFetchConnection: Prefer boolean operators over logical operators in comparisons
Using the | and & operators in boolean conditions results in a warning
from Error Prone:
[ShortCircuitBoolean]
Prefer the short-circuiting boolean operators && and || to & and |.
see https://errorprone.info/bugpattern/ShortCircuitBoolean
Change-Id: I6cccca3fdd28bf93b302a9b8a66e68ac912cb60d
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
Diffstat (limited to 'org.eclipse.jgit/src')
| -rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackFetchConnection.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackFetchConnection.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackFetchConnection.java index a61c243bdf..57d6bc2466 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackFetchConnection.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackFetchConnection.java @@ -670,7 +670,7 @@ public abstract class BasePackFetchConnection extends BasePackConnection } } - if (noDone & receivedReady) { + if (noDone && receivedReady) { break SEND_HAVES; } if (statelessRPC) { |