summaryrefslogtreecommitdiffstats
path: root/org.eclipse.jgit
diff options
context:
space:
mode:
authorStefan Beller <sbeller@google.com>2016-07-21 14:21:57 -0700
committerStefan Beller <sbeller@google.com>2016-07-25 10:10:06 -0700
commit1556ca740b75661a2670ddcb581dafced3010bae (patch)
treef09627ad7abe0476e43349be81400b35dd7af33c /org.eclipse.jgit
parente9e2f7e6b5c075518bb4a744513558956dd099bf (diff)
downloadjgit-1556ca740b75661a2670ddcb581dafced3010bae.tar.gz
jgit-1556ca740b75661a2670ddcb581dafced3010bae.zip
RefSpec: reject refs ending in '/'
We had a case in Gerrits superproject subscriptions where 'refs/heads/' was configured with the intention to mean 'refs/heads/*'. The first expression lacks the '*', which is why it is not considered a wildcard but it was considered valid and so was not found early to be a typo. Refs are not allowed to end with '/' anyway, so add a check for that. Change-Id: I3ffdd9002146382acafb4fbc310a64af4cc1b7a9 Signed-off-by: Stefan Beller <sbeller@google.com>
Diffstat (limited to 'org.eclipse.jgit')
-rw-r--r--org.eclipse.jgit/src/org/eclipse/jgit/transport/RefSpec.java2
1 files changed, 2 insertions, 0 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/RefSpec.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/RefSpec.java
index 0e803bdaf7..cbc6cc021a 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/RefSpec.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/RefSpec.java
@@ -453,6 +453,8 @@ public class RefSpec implements Serializable {
return false;
if (s.contains("//")) //$NON-NLS-1$
return false;
+ if (s.endsWith("/")) //$NON-NLS-1$
+ return false;
int i = s.indexOf('*');
if (i != -1) {
if (s.indexOf('*', i + 1) > i)