[errorprone] fix ReturnValueIgnored in PushCertificateStore#next

Change-Id: I8deb7fa702bb973436b7ca21edf3634a087047b7

1 files changed, 3 insertions, 4 deletions

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateStore.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateStore.java
index 5634ac0843..a9e93b6be6 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateStore.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateStore.java
@@ -159,7 +159,7 @@ public class PushCertificateStore implements AutoCloseable {
 	 *         close resources.
 	 */
 	public Iterable<PushCertificate> getAll(String refName) {
-		return () -> new Iterator<PushCertificate>() {
+		return () -> new Iterator<>() {
 			private final String path = pathName(refName);
 
 			private PushCertificate next;
@@ -219,11 +219,10 @@ public class PushCertificateStore implements AutoCloseable {
 
 			@Override
 			public PushCertificate next() {
-				hasNext();
-				PushCertificate n = next;
-				if (n == null) {
+				if (!hasNext()) {
 					throw new NoSuchElementException();
 				}
+				PushCertificate n = next;
 				next = null;
 				return n;
 			}