diff options
| author | David Pursehouse <david.pursehouse@gmail.com> | 2020-01-27 09:47:05 +0900 |
|---|---|---|
| committer | Matthias Sohn <matthias.sohn@sap.com> | 2020-01-27 14:40:08 +0100 |
| commit | 4cc13297ccf1fa3e982bbb5638162b3bad63f93c (patch) | |
| tree | 3f0b0c0aead716773d569e0b2eb1efb3b6f02081 /tools | |
| parent | 0e4a717870f64e667e657650f12e93d477d369c3 (diff) | |
| download | jgit-4cc13297ccf1fa3e982bbb5638162b3bad63f93c.tar.gz jgit-4cc13297ccf1fa3e982bbb5638162b3bad63f93c.zip | |
ErrorProne: Enable and fix UnusedException check
Enable UnusedException at ERROR level which causes the build to fail
in many places with:
[UnusedException] This catch block catches an symbol and re-throws
another, but swallows the caught symbol rather than setting it as a
cause. This can make debugging harder.
Fix it by setting the caught exception as cause on the subsequently
thrown exception.
Note: The grammatically incorrect error message is copy-pasted as-is
from the version of ErrorProne currently used in Bazel; it has been
fixed by [1] in the latest version.
[1] https://github.com/google/error-prone/commit/d57a39c
Change-Id: I11ed38243091fc12f64f1b2db404ba3f1d2e98b5
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/BUILD | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/BUILD b/tools/BUILD index d66837700c..2b208744b5 100644 --- a/tools/BUILD +++ b/tools/BUILD @@ -78,6 +78,7 @@ java_package_configuration( "-Xep:TypeParameterShadowing:ERROR", "-Xep:TypeParameterUnusedInFormals:WARN", "-Xep:URLEqualsHashCode:ERROR", + "-Xep:UnusedException:ERROR", "-Xep:UnsynchronizedOverridesSynchronized:ERROR", "-Xep:WaitNotInLoop:ERROR", ], |