diff options
| author | David Pursehouse <david.pursehouse@gmail.com> | 2019-06-22 18:40:49 +0900 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@gmail.com> | 2019-06-22 18:44:23 +0900 |
| commit | dad9e1ff95b292661bd3aec6292cf4ae4d62a5bb (patch) | |
| tree | 47209bade33fee13e8d9ad58c8b915fdfabac4a5 /tools | |
| parent | 99a5fa22834e830e043938883cd610a96a04528c (diff) | |
| download | jgit-dad9e1ff95b292661bd3aec6292cf4ae4d62a5bb.tar.gz jgit-dad9e1ff95b292661bd3aec6292cf4ae4d62a5bb.zip | |
GlobalBundleCache: Fix ClassNewInstance warning from Error Prone
Error Prone reports:
[ClassNewInstance] Class.newInstance() bypasses exception checking;
prefer getDeclaredConstructor().newInstance()
See https://errorprone.info/bugpattern/ClassNewInstance
This was the only occurrence of the warning in the code base; now it's
fixed, increase the severity to ERROR to prevent future occurrences.
Change-Id: Ic04d1c5d2bd458bbb4bb399d6ce9d147bd48d0b1
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/BUILD | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/BUILD b/tools/BUILD index 9abecc5f72..20c82c5700 100644 --- a/tools/BUILD +++ b/tools/BUILD @@ -32,7 +32,7 @@ java_package_configuration( "-Xep:BoxedPrimitiveConstructor:ERROR", "-Xep:CannotMockFinalClass:ERROR", "-Xep:ClassCanBeStatic:ERROR", - "-Xep:ClassNewInstance:WARN", + "-Xep:ClassNewInstance:ERROR", "-Xep:DefaultCharset:ERROR", "-Xep:DoubleCheckedLocking:ERROR", "-Xep:ElementsCountedInLoop:ERROR", |