summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | Update maven-shade-plugin to 3.2.4Matthias Sohn2020-12-241-1/+1
| | | | | | | | Change-Id: Id3eb7c8ab5ce37b6079bbf9a4cb1974ba70ace8a
* | Require latest Maven version 3.6.3Matthias Sohn2020-12-243-2/+22
| | | | | | | | | | Change-Id: Iab08ddcdb7edc3c9ac55343d3d40012e19792ea0 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Update spring-boot-maven-plugin to 2.4.1Matthias Sohn2020-12-241-1/+1
| | | | | | | | | | Change-Id: I68a6c04a5c7e674410736a45ef0031a2c369a321 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Update maven-surefire plugins to 3.0.0-M5Matthias Sohn2020-12-242-2/+2
| | | | | | | | | | Change-Id: I0425029eac630f4e8fb47d112d086e74283b2ebd Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Update japicmp-maven-plugin to 0.14.4Matthias Sohn2020-12-241-1/+1
| | | | | | | | | | Change-Id: I33ba5388153e6941713b9c9425cd917e9769a177 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Update spotbugs-maven-plugin to 4.1.4Matthias Sohn2020-12-241-1/+1
| | | | | | | | | | Change-Id: Ie231dc03051f3c8d799f037eeeed8dcaad258fe0 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Upgrade ecj to 3.24.0Marco Miller2020-12-241-1/+1
| | | | | | | | | | Change-Id: I81c03c5f916e97f91cf06dbe3ce355e430b2981a Signed-off-by: Marco Miller <marco.miller@ericsson.com>
* | Upgrade wagon-ssh to 3.4.2; align maven-site-pluginMarco Miller2020-12-243-4/+4
| | | | | | | | | | | | | | | | Upgrade wagon-ssh to 3.4.2 in all pom files, thus align maven-site-plugin versions to 3.9.1 across as well, consistently. Change-Id: I38f7a6ded3517d1b116169dee1c12deb86eed3a1 Signed-off-by: Marco Miller <marco.miller@ericsson.com>
* | [spotbugs] Fix incorrect lazy initialization in SystemReaderMatthias Sohn2020-12-221-2/+2
| | | | | | | | | | | | This fixes two warnings of type LI_LAZY_INIT_STATIC. Change-Id: I26a7a48aed9d0a0547e908a56b7014a7620fadd8 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Don't use class from java.util.concurrent for lockingMatthias Sohn2020-12-221-1/+3
| | | | | | | | | | | | | | | | Use a dedicated Lock object to lock the scheduler in RepositoryCache#configureEviction to fix spotbugs warning JLM_JSR166_UTILCONCURRENT_MONITORENTER. Change-Id: I003dcf0ed1a0a3f4eea5d8a2f51a07473d28a928 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Fix potential NPE in OpenSshServerKeyDatabaseMatthias Sohn2020-12-221-1/+4
| | | | | | | | | | | | | | | | | | If oldLine is null #updateModifiedServerKey shouldn't be called since it would derefence it. Spotbugs raised this as problem RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE. Fix it by checking if oldLine is null before calling #updateModifiedServerKey. Change-Id: I8a2000492986e52ce7dbe25f48b321c05fd371e4 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Fix potential NPE in FS.FileStoreAttributes#getMatthias Sohn2020-12-221-0/+3
| | | | | | | | | | | | | | Path#getParent can return null, return fallback filestore attributes in that case. Change-Id: Ic09484d527bc87b27964b625e07373b82412f2da Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Silence CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE in jgit testsMatthias Sohn2020-12-222-0/+154
| | | | | | | | | | | | | | We want complete control over clone behavior and don't want to use Object's clone implementation. Change-Id: I34a4e967f8aa3879c69a4978768bd35712c4105c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Silence NP_BOOLEAN_RETURN_NULL in FakeUserAuthGSS#doAuthMatthias Sohn2020-12-223-1/+156
| | | | | | | | | | | | Also mark the return value @Nullable to enable null analysis in Eclipse. Change-Id: Ib954b231d743da6ea122adb2cc4880b5f99824cc Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Fix FileReftableStack#equals to check for nullMatthias Sohn2020-12-221-0/+3
| | | | | | | | | | | | | | | | | | | | | | This fixes spotbugs warning NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT. This implementation violated the contract defined by java.lang.Object.equals() because it did not check for null being passed as the argument. All equals() methods should return false if passed a null value. Change-Id: I607f6979613d390aae2f3546b587f63133d6d73c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] FileReftableDatabase: extract lock to local variableMatthias Sohn2020-12-221-2/+4
| | | | | | | | | | | | | | This fixes UL_UNRELEASED_LOCK_EXCEPTION_PATH raised by spotbugs in #compactFully. Change-Id: I370578ad9a027c5c9709d60a1dfafdac0cfca908 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] DfsReftableDatabase: extract lock to local variableMatthias Sohn2020-12-221-4/+7
| | | | | | | | | | | | | | This fixes UL_UNRELEASED_LOCK_EXCEPTION_PATH raised by spotbugs in #DfsReftableDatabase and #clearCache. Change-Id: Ifd3189288d2a8e64139c02cd105eb335fa2f68cf Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Silence NP_BOOLEAN_RETURN_NULL in IgnoreNode#checkIgnoredMatthias Sohn2020-12-222-1/+10
| | | | | | | | | | | | Also mark the return value @Nullable to enable null analysis in Eclipse. Change-Id: I5b286d657d432f4b32afd4dd370f76892b115422 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Silence warning DLS_DEAD_LOCAL_STORE in generated classesMatthias Sohn2020-12-222-0/+153
| | | | | | | | Change-Id: I714f5fa48a2443d1a8e2c640b204d3e32438910e Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | [spotbugs] Silence warning about unwritten field written by gsonMatthias Sohn2020-12-221-0/+8
| | | | | | | | | | | | | | It seems spotbugs does not recognize that this data is written by gson. Change-Id: I0704d489971c0ab6ec398083f211c409061e7661 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Merge branch 'stable-5.10'Matthias Sohn2020-12-222-3/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | * stable-5.10: Update jgit-4.18 target platform to use release repository Change-Id: I1bc7b6d38085ba31fa65ad882a4f991da27bbf72 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| * | Update jgit-4.18 target platform to use release repositoryMatthias Sohn2020-12-172-3/+3
| | | | | | | | | | | | Change-Id: I62aaf1cb823e05f277b16b156d0f9a4928efe213
* | | Revert "Remove unused API problem filters"Matthias Sohn2020-12-221-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 022b02dea10612cb01f9694212b72bd1bbd69cb9. Removing this API warning filter was wrong since we intentionally removed the config constant CONFIG_REFSTORAGE_REFTREE. Change-Id: Ie068e539157cc2312efc8a07feabeb0dd2f75096 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | Remove unused API problem filtersMatthias Sohn2020-12-171-11/+0
| | | | | | | | | | | | | | | Change-Id: Id533cf598cd37c277b4de06fdd8ae74cfeede4d0 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPE in FS#writeMatthias Sohn2020-12-171-1/+4
| | | | | | | | | | | | | | | | | | Path#getParent can return null. Change-Id: I01f13ac426dda4c007cc5caab546a0c9be62ce76 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPE in PackFileSnapshotTestMatthias Sohn2020-12-171-2/+6
| | | | | | | | | | | | | | | | | | | | | Path#getFileName can return null. Fix the warning by asserting the file name isn't null. Change-Id: I7f2fe75b46113d8be1d14e3f18dd77da27df25ed Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPEs in FileReftableStackTestMatthias Sohn2020-12-171-7/+12
| | | | | | | | | | | | | | | | | | | | | File#listFiles can return null. Use Files#list instead to fix the problem. Change-Id: I74e0b49aa6dae370219507c64aa43be4d8aa7b82 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPE in WorkingTreeIterator#isModifiedMatthias Sohn2020-12-171-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | File#list can return null. Fix the potential NPE by using Files#list which is also faster since it retrieves directory entries lazily while File#list retrieves them eagerly. Change-Id: Idf4bda398861c647587e357326b8bc8b587a2584 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPE in FileBasedConfigTestMatthias Sohn2020-12-171-3/+10
| | | | | | | | | | | | | | | | | | | | | Path#getParent can return null. Fix the warning by implementing a helper method which asserts the parent is not null. Change-Id: Ib4f8dff0674b74bc891f15f08bd9755c5ea728dc Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPE in GcPruneNonReferencedTestMatthias Sohn2020-12-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | File#listFiles can return null, assert it is not null to fix the warning. Change-Id: I28fc668fee760d39965e6e039003ac9f85fd461b Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] Fix potential NPE in FileRepository#convertToReftableMatthias Sohn2020-12-171-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | File#listFiles can return null. Use Files#list which does not return null and should be faster since it's returning directory entries lazily while File#listFiles fetches them eagerly. Change-Id: I3bfe2a52278244fc469143692c06b05d9af0d0d4 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] silence warnings for intended use of == to compare stringsMatthias Sohn2020-12-171-2/+20
| | | | | | | | | | | | Change-Id: Ib6967ad4deb5cf233d1f1d714cd094da5fad48e3 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] silence short-circuit warning in PackOutputStream#writeMatthias Sohn2020-12-171-0/+6
| | | | | | | | | | | | Change-Id: I47b7a7991afae0dd1e678bd5e1f8e81599791e5f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [spotbugs] parse time using thread-safe DateTimeFormatterMatthias Sohn2020-12-171-5/+9
| | | | | | | | | | | | | | | | | | | | | LfsConnectionFactory used a static SimpleDateFormat which isn't thread-safe. Use DateTimeFormatter instead to fix this. Change-Id: Id580251c999e1e412c269f37b29860d310124c89 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | FetchProcess#execute: fix formattingMatthias Sohn2020-12-171-2/+3
| | | | | | | | | | | | Change-Id: I133af64e6b165bdc58b8d7c805f0c68b6919baf2 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [errorprone] FetchProcess: ensure exception isn't suppressedMatthias Sohn2020-12-171-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | If TransportException is thrown in the finally block of execute() ensure that the exception handled in the previous catch block isn't suppressed. Change-Id: I670acdfb4d36e7a419a9a79ae9faab2e085a43ee Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | [errorprone] WalkFetchConnection: ensure exception isn't suppressedMatthias Sohn2020-12-171-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | If TransportException is thrown in the finally block of downloadPackedObject() ensure that the exception handled in the previous catch block isn't suppressed. Change-Id: I23982a2b215e38f681cc1719788985e60232699a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | Remove unused API problem filtersMatthias Sohn2020-12-151-52/+0
| | | | | | | | | | | | Change-Id: I982f21dfaec4e35818eca7a4793e24a2cec4e467 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | Remove reftree and ketchHan-Wen Nienhuys2020-12-1553-7805/+13
| | | | | | | | | | | | | | | | | | | | | This was experimental code and never used in production. Change-Id: Ia3da7f2b82d9e365cec2ccf9397cbc47439cd150 Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | LsRemote: suppress warning for non-externalized stringMatthias Sohn2020-12-151-1/+1
| | | | | | | | | | | | Change-Id: Ic1d8f2eef4a8de0a75d5b523b584b1ac275a8811 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | LooseObjects: fix formattingMatthias Sohn2020-12-151-13/+13
| | | | | | | | | | | | Change-Id: I992e5066d1dc4603e5bae991b26605d319f5cdc2 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | Split out loose object handling from ObjectDirectoryMartin Fick2020-12-152-120/+245
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ObjectDirectory class manages the interactions for the entire object database, this includes loose objects, packfiles, alternates, and shallow commits. To help reduce the complexity of this class, abstract some of the loose object specific details into a class which understands just this, leaving the ObjectDirectory to focus more on the interactions between the different mechanisms. Change-Id: I39f3a74d6308f042a2a2baa57769f4acde5ba5e0 Signed-off-by: Martin Fick <mfick@codeaurora.org> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | Merge branch 'stable-5.9'Matthias Sohn2020-12-141-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-5.9: Fix stamping to produce stable file timestamps Change-Id: Icd092cd9b883556fcbd115c17346a9d88dc172ce Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| * | | Fix stamping to produce stable file timestampsDavid Ostrovsky2020-12-141-1/+1
| | | | | | | | | | | | | | | | Change-Id: I628ab5feb4a70f81ec832f1b81d1ad3a9caca615
* | | | PackDirectory: fix formattingMatthias Sohn2020-12-121-24/+41
| | | | | | | | | | | | | | | | Change-Id: I10586981323529c7e9041110ebb58033e7180194 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | | Split out packfile handling from ObjectDirectoryMartin Fick2020-12-122-377/+513
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ObjectDirectory class manages the interactions for the entire object database, this includes loose objects, packfiles, alternates, and shallow commits. To help reduce the complexity of this class, abstract some of the packfile specific details into a class which understands just this, leaving the ObjectDirectory to focus more on the interactions between the different mechanisms. Change-Id: I5cc87b964434b0afa860b3fe23867a77b3c3a4f2 Signed-off-by: Martin Fick <mfick@codeaurora.org> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | | TagCommand: propagate NO_CHANGE informationThomas Wolf2020-12-083-36/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some clients may wish to allow NO_CHANGE lightweight tag updates without setting the force flag. (For instance EGit does so.) Command-line git does not allow this. Propagate the RefUpdate result via the RefAlreadyExistsException. That way a client has the possibility to catch it and check the failure reason without having to parse the exception message, and take appropriate action, like ignoring the exception on NO_CHANGE. Change-Id: I60e7a15a3c309db4106cab87847a19b6d24866f6 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
* | | | TagCommand: make -f work with lightweight tags for NO_CHANGEThomas Wolf2020-12-082-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | JGit treated a NO_CHANGE RefUpdate as an error in all cases. But when updating a lightweight tag, this is a successful result if -f was specified. Change-Id: Iddfa6d6a6dc8bf8fed81138a008ebc32d5f960bd Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
* | | | Merge branch 'stable-5.10'Matthias Sohn2020-12-080-0/+0
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | * stable-5.10: Prepare 5.10.1-SNAPSHOT builds JGit v5.10.0.202012080955-r Change-Id: I751f55944d2aebbd622dda8acd8c113208a972eb Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| * | | Prepare 5.10.1-SNAPSHOT buildsMatthias Sohn2020-12-0888-506/+506
| | | | | | | | | | | | | | | | | | | | Change-Id: If1e44edfa0a80a29c00ed5112291d1338baf56f1 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>