summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | CommitGraph: add commit-graph for FileObjectDatabasekylezhao2022-12-237-0/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change makes JGit can read .git/objects/info/commit-graph file and then get CommitGraph. Loading a new commit-graph into memory requires additional time. After testing, loading a copy of the Linux's commit-graph(1039139 commits) is under 50ms. Bug: 574368 Change-Id: Iadfdd6ed437945d3cdfdbe988cf541198140a8bf Signed-off-by: kylezhao <kylezhao@tencent.com>
* | | | | | | | PatchApplier: fix handling of last newline in text patchThomas Wolf2022-12-2638-18/+1358
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the last line came from the patch, use the patch to determine whether or not there should be a trailing newline. Otherwise use the old text. Add test cases for - no newline at end, last line not in patch hunk - no newline at end, last line in patch hunk - patch removing the last newline - patch adding a newline at the end of file not having one all for core.autocrlf false, true, and input. Add a test case where the "no newline" indicator line is not the last line of the last hunk. This can happen if the patch ends with removals at the file end. Bug: 581234 Change-Id: I09d079b51479b89400ad300d0662c1dcb50deab6 Also-by: Yuriy Mitrofanov <a2terminator@mail.ru> Signed-off-by: Thomas Wolf <twolf@apache.org>
* | | | | | | | Reformat PatchApplier and PatchApplierTestThomas Wolf2022-12-222-59/+65
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some lines were too long, unnecessary fully qualified class names, and an assertEquals(actual, expected) when it should have been assertEquals(expected, actual). Change-Id: I3b3c46c963afe2fb82a79c1e93970e73778877e5 Signed-off-by: Thomas Wolf <twolf@apache.org>
* | | | | | | PackWriter#prepareBitmapIndex: add clarifying commentsAnna Papitto2022-12-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | New readers of #prepareBitmapIndex may be confused about the manual memory management (hidden mutation and nulling out pointers). Add two clarifying comments to help future readers. Change-Id: I93cab1919066efda37e96c47667f6991f67e377e
* | | | | | | Merge "IO#readFully: provide overload that fills the full array"Ivan Frade2022-12-192-2/+21
|\ \ \ \ \ \ \
| * | | | | | | IO#readFully: provide overload that fills the full arrayAnna Papitto2022-12-192-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IO#readFully is often called with the intent to fill the destination array from beginning to end. The redundant arguments for where to start and stop filling are opportunities for bugs if specified incorrectly or if not changed to match a changed array length. Provide a overloaded method for filling the full destination array. Change-Id: I964f18f4a061189cce1ca00ff0258669277ff499 Signed-off-by: Anna Papitto <annapapitto@google.com>
* | | | | | | | Fix API warnings for the new CommitGraphThomas Wolf2022-12-172-1/+13
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mark the internal package as internal, visible only to the test bundle. Add an API filter for CoreConfig.DEFAULT_COMMIT_GRAPH_ENABLE. Change-Id: Ib62a93b873c93daf638b6c57e62fd267e16801bb Signed-off-by: Thomas Wolf <twolf@apache.org>
* | | | | | | PackReverseIndex#findPosition: fix typo in method nameAnna Papitto2022-12-162-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The package-private findPostion method has a type in it. The typo will become more widespread when a file-based implementation class is introduced. Correct the spelling to findPosition before the file-based implementation is introduced. Change-Id: Ib285f5a3f9a333ace1782dae9b5d425505eb962a Signed-off-by: Anna Papitto <annapapitto@google.com>
* | | | | | | GC: Write commit-graph files when gckylezhao2022-12-164-0/+268
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If 'core.commitGraph' and 'gc.writeCommitGraph' are both true, then gc will rewrite the commit-graph file when 'git gc' is run. Defaults to false while the commit-graph feature matures. Bug: 574368 Change-Id: Ic94cd69034c524285c938414610f2e152198e06e Signed-off-by: kylezhao <kylezhao@tencent.com>
* | | | | | | CommitGraph: add core.commitGraph configkylezhao2022-12-163-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I3b5e735ebafba09ca18fd83da479c7950fa3ea8d Signed-off-by: kylezhao <kylezhao@tencent.com>
* | | | | | | Merge "Gc#deleteOrphans: avoid dependence on PackExt alphabetical ordering"Ivan Frade2022-12-162-35/+69
|\ \ \ \ \ \ \
| * | | | | | | Gc#deleteOrphans: avoid dependence on PackExt alphabetical orderingAnna Papitto2022-12-152-35/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deleting orphan files depends on .pack and .keep being reverse-sorted to before the corresponding index files that could be orphans. The new reverse index file extension (.rev) will break that frail dependency. Rewrite Gc#deleteOrphans to avoid that dependence by tracking which pack names have a .pack or .keep file and then deleting any index files that without a corresponding one. This approach takes linear time instead of the O(n logn) time needed for sorting. Change-Id: If83c378ea070b8871d4b01ae008e7bf8270de763 Signed-off-by: Anna Papitto <annapapitto@google.com>
* | | | | | | | CommitGraph: implement commit-graph readkylezhao2022-12-1613-0/+1216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Git introduced a new file storing the topology and some metadata of the commits in the repo (commitGraph). With this data, git can browse commit history without parsing the pack, speeding up e.g. reachability checks. This change teaches JGit to read commit-graph-format file, following the upstream format([1]). JGit can read a commit-graph file from a buffered stream, which means that we can provide this feature for both FileRepository and DfsRepository. [1] https://git-scm.com/docs/commit-graph-format/2.21.0 Bug: 574368 Change-Id: Ib5c0d6678cb242870a0f5841bd413ad3885e95f6 Signed-off-by: kylezhao <kylezhao@tencent.com>
* | | | | | | | WalkPushConnection: Sanitize paths given to transportsJeremy T. Braun2022-12-151-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These paths are given to the underlying URI-based transports (s3, sftp, http), all of which expect forward-slash as the path separator character. Change-Id: I3cbb5928c9531a4da4691411bd8ac248fdf47ef2
* | | | | | | | Merge changes Iad832fe1,Icef9658cMatthias Sohn2022-12-1414-214/+116
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * changes: CommitGraphWriter: fix UnusedException errorprone error Update jetty to 10.0.13
| * | | | | | | | CommitGraphWriter: fix UnusedException errorprone errorMatthias Sohn2022-12-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Errorprone run in the bazel build raised this exception: org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java:105: error: [UnusedException] This catch block catches an exception and re-throws another, but swallows the caught exception rather than setting it as a cause. This can make debugging harder. } catch (InterruptedIOException e) { ^ (see https://errorprone.info/bugpattern/UnusedException) Did you mean 'throw new IOException(JGitText.get().commitGraphWritingCancelled, e);'? Change-Id: Iad832fe17955fc1e60e6a4902bc50fd9dca76b9d
| * | | | | | | | Update jetty to 10.0.13Matthias Sohn2022-12-1313-213/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Oomph's p2 repo for jetty 10.0.13 doesn't have source bundles, we remove them. Eclipse platform doesn't create p2 repos for jetty anymore and we aren't yet ready to use maven dependencies like the platform does. Change-Id: Icef9658ce441be43931e32d931adf717e2fa222c
* | | | | | | | | GraphCommits: Remove unused getter by positionIvan Frade2022-12-131-7/+0
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CommitGraphWriter uses the GraphCommits in for-each loops and doesn't need the access by position anymore. This was a left-over from https://git.eclipse.org/r/c/jgit/jgit/+/182832 Remove the unused method. Change-Id: I39df9bfab2601d581705ddf4cea3c04ed4765ff9
* | | | | | | | PackExt: Add a commit graph extension.Xing Huang2022-12-121-1/+4
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no commit graph PackExt because the non-DFS stack is not writing using PackExt mechanism. The extension is needed in DFS to determine the stream to write the commit-graph. Add a commit graph extension that matches the one in cgit (https://git-scm.com/docs/commit-graph#_file_layout) in preparation for adding DFS support for reading and writing commit graphs. Change-Id: Id14eda9f116a319124981e0bcbc533928b1b5e8c Signed-off-by: Xing Huang <xingkhuang@google.com>
* | | | | | | Merge "commitgraph package: fix exports/imports, add @since tag for new API"Matthias Sohn2022-12-084-0/+6
|\ \ \ \ \ \ \
| * | | | | | | commitgraph package: fix exports/imports, add @since tag for new APIMatthias Sohn2022-12-084-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I9175b1d796f91f5ba4e21d3418550ae451c054b0
* | | | | | | | BatchRefUpdate: Consistent switch branches in ref updateSergey2022-12-081-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The expression RefUpdate ru = newUpdate(cmd) is eagerly evaluated before the switch statement. But it is not used in some switch cases and thus is calculated uselessly. Move expression evaluation to the switch case where it is actually used. After such a move, several cases became identical and thus were squashed. Change-Id: Ifd1976f1c28378e092fb24d7ca9c415cba49f07f
* | | | | | | | RefWriter#writePackedRefs: Remove a redundant "if" checkSergey2022-12-081-2/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After checking the variable, the same variable was checked again inside the "if" block, and after the first check, this variable does not change. Remove the second unnecessary check. Change-Id: I6a38e67073f7f93105575b8f415ad32d350af602
* | | | | | | Merge "CommitGraph: implement commit-graph writer"Ivan Frade2022-12-069-0/+800
|\ \ \ \ \ \ \
| * | | | | | | CommitGraph: implement commit-graph writerkylezhao2022-12-069-0/+800
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Teach JGit to write a commit-graph formatted file by walking commit graph from specified commit objects. See: https://git-scm.com/docs/commit-graph-format/2.21.0 Bug: 574368 Change-Id: I34f9f28f8729080c275f86215ebf30b2d05af41d Signed-off-by: kylezhao <kylezhao@tencent.com>
* | | | | | | | [releng] bump japicmp base versionThomas Wolf2022-12-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bump the japicmp base version to 6.4.0.202211300538-r. (Up from 6.2.0. We forgot to bump in the 6.4.0 release cycle.) Change-Id: Ied39865563fb57f5ee9059241449e5e101e75d86 Signed-off-by: Thomas Wolf <twolf@apache.org>
* | | | | | | | Merge branch 'stable-6.4'Matthias Sohn2022-11-300-0/+0
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| / / / / / / | |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-6.4: Prepare 6.4.1-SNAPSHOT builds JGit v6.4.0.202211300538-r Fix crashes on rare combination of file names Change-Id: I9b5c5f408d1d45868c138c15675346a6693ab998
| * | | | | | Prepare 6.4.1-SNAPSHOT buildsMatthias Sohn2022-11-3091-529/+529
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I860bfde113c05015c41304c4a77c44c224bd0923
| * | | | | | JGit v6.4.0.202211300538-rv6.4.0.202211300538-rMatthias Sohn2022-11-3091-125/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: If4001b255a209849b4acabd2083164d0794f00c4
| * | | | | | Fix crashes on rare combination of file namesDmitrii Filippov2022-11-293-4/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The NameConflictTreeWalk class is used in merge for iterating over entries in commits. The class uses a separate iterator for each commit's tree. In rare cases it can incorrectly report the same entry twice. As a result, duplicated entries are added to the merge result and later jgit throws an exception when it tries to process merge result. The problem appears only when there is a directory-file conflict for the last item in trees. Example from the bug: Commit 1: * subtree - file * subtree-0 - file Commit 2: * subtree - directory * subtree-0 - file Here the names are ordered like this: "subtree" file <"subtree-0" file < "subtree" directory. The NameConflictTreeWalk handles similar cases correctly if there are other files after subtree... in commits - this is processed in the AbstractTreeIterator.min function. Existing code has a special optimization for the case, when all trees are pointed to the same entry name - it skips additional checks. However, this optimization incorrectly skips checks if one of trees reached the end. The fix processes a situation when some trees reached the end, while others are still point to an entry. bug: 535919 Change-Id: I62fde3dd89779fac282479c093400448b4ac5c86
* | | | | | | Merge "Fix crashes on rare combination of file names"Han-Wen NIenhuys2022-11-283-4/+216
|\ \ \ \ \ \ \
| * | | | | | | Fix crashes on rare combination of file namesDmitrii Filippov2022-11-033-4/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The NameConflictTreeWalk class is used in merge for iterating over entries in commits. The class uses a separate iterator for each commit's tree. In rare cases it can incorrectly report the same entry twice. As a result, duplicated entries are added to the merge result and later jgit throws an exception when it tries to process merge result. The problem appears only when there is a directory-file conflict for the last item in trees. Example from the bug: Commit 1: * subtree - file * subtree-0 - file Commit 2: * subtree - directory * subtree-0 - file Here the names are ordered like this: "subtree" file <"subtree-0" file < "subtree" directory. The NameConflictTreeWalk handles similar cases correctly if there are other files after subtree... in commits - this is processed in the AbstractTreeIterator.min function. Existing code has a special optimization for the case, when all trees are pointed to the same entry name - it skips additional checks. However, this optimization incorrectly skips checks if one of trees reached the end. The fix processes a situation when some trees reached the end, while others are still point to an entry. bug: 535919 Change-Id: I62fde3dd89779fac282479c093400448b4ac5c86
* | | | | | | | Prepare 6.5.0-SNAPSHOT buildsMatthias Sohn2022-11-2391-529/+529
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I4238b6181e96e22e540cf34802a332f868cb6dfb
* | | | | | | | Merge branch 'stable-6.4'Matthias Sohn2022-11-230-0/+0
|\ \ \ \ \ \ \ \ | | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-6.4: Prepare 6.4.0-SNAPSHOT build JGit v6.4.0.202211231055-rc1 Change-Id: I5bf49cb31d8c401e8f8f12a69d96ac8b42ff3605
| * | | | | | | Prepare 6.4.0-SNAPSHOT buildMatthias Sohn2022-11-2391-125/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I41c4f73472bb47d8f9d2d117d17e11bba4802928
| * | | | | | | JGit v6.4.0.202211231055-rc1v6.4.0.202211231055-rc1Matthias Sohn2022-11-2391-125/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: Ia34696d07568b298544ee2cdc6f4b6746774bb82
| * | | | | | | Merge branch 'master' into stable-6.4Matthias Sohn2022-11-2358-474/+907
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: [pgm] Add options --name-only, --name-status to diff, log, show Update Orbit to R20221123021534 for 2022-12 RBE: Update toolchain with bazel-toolchains 5.1.2 release SshTestGitServer: : ensure UploadPack is closed to fix resource leak UploadPackTest: ensure UploadPack is closed to fix resource leak [pgm] Ensure UploadPack is closed to fix resource leak UploadPackServlet#doPost use try-with-resource to ensure up is closed Fix warnings in PatchApplierTest Fix boxing warnings in TransportTest Silence warnings about unclosed BasePackPushConnection Fix warning about non-externalized String Remove unused imports Suppress non-externalized String warnings Remove unused API problem filters Silence API errors Silence API errors Silence API warnings Add 4.26 target platform Use "releases" repository for 4.25 target platform Update Apache Mina SSHD to 2.9.2 Update Orbit to S20221118032057 DfsBlockCache: Report IndexEventConsumer metrics for reverse indexes. DfsStreamKey: Replace ForReverseIndex to separate metrics. RawText.isBinary(): handle complete buffer correctly PackExt: Add a reverse index extension. Change-Id: Ia41a2b0662bdb174e05a1adba6502191ef5ce4c5
* | | | | | | | [pgm] Add options --name-only, --name-status to diff, log, showalerthak2022-11-239-10/+307
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ib218bd2ccbd7990feca4c35d8c8dc34d4a8291e6
* | | | | | | | Update Orbit to R20221123021534 for 2022-12Matthias Sohn2022-11-2321-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I9de11cc198ce3926d5233c4e30dc74f36674d3b5
* | | | | | | | RBE: Update toolchain with bazel-toolchains 5.1.2 releaseDavid Ostrovsky2022-11-231-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to this platform style migration: [1] the RBE toolchain needs to be updated to use the latest rbe_config_gen from bazel-toolchains (at least version 5.1.2 so that it contains: [2]). This change makes RBE build forwards compatible so that Bazel could be updated to the upcoming major 6.0 release. [1] https://github.com/bazelbuild/bazel/issues/8622 [2] https://github.com/bazelbuild/bazel-toolchains/commit/8c717f8258cd5f6c7a45b97d974292755852b658 Change-Id: Ia3a108fa05b1d52cd2018ba901ffd4c9e55ae8ab
* | | | | | | | SshTestGitServer: : ensure UploadPack is closed to fix resource leakMatthias Sohn2022-11-211-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ib766f1d56b3ca7940c593ebfe0ac68fc5028a11c
* | | | | | | | UploadPackTest: ensure UploadPack is closed to fix resource leakMatthias Sohn2022-11-211-37/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I4c8cf6041b4011934d338138d4531d190fdd6abb
* | | | | | | | [pgm] Ensure UploadPack is closed to fix resource leakMatthias Sohn2022-11-211-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I40da4b331012dd1c6f4b497e46c973fd776b737f
* | | | | | | | UploadPackServlet#doPost use try-with-resource to ensure up is closedMatthias Sohn2022-11-211-28/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Iadbf81f183bb94f3b00b9940f065586b13e85c95
* | | | | | | | Fix warnings in PatchApplierTestMatthias Sohn2022-11-201-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - don't use final for method parameters - fix hiding member warnigns Change-Id: I73c386f669918d3291ee3380024c018483aa3c97
* | | | | | | | Fix boxing warnings in TransportTestMatthias Sohn2022-11-201-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I7e6dc845b89899cff262fab77c3977dbef5eea02
* | | | | | | | Silence warnings about unclosed BasePackPushConnectionMatthias Sohn2022-11-201-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: If52e8462e6222dd58d1004dd5ac174a27d96d098
* | | | | | | | Fix warning about non-externalized StringMatthias Sohn2022-11-201-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I00b2132eac6d6ad2701d3f8151eb8c80ad6d679d
* | | | | | | | Merge branch 'stable-6.3'Matthias Sohn2022-11-208-18/+17
|\ \ \ \ \ \ \ \ | | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-6.3: Remove unused imports Suppress non-externalized String warnings Remove unused API problem filters Silence API errors Silence API errors Silence API warnings Change-Id: I6778c8266bc7e918c943dcabf23aa230f4e998d5
| * | | | | | | Merge branch 'stable-6.2' into stable-6.3Matthias Sohn2022-11-209-46/+17
| |\ \ \ \ \ \ \ | | | |_|/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-6.2: Remove unused imports Suppress non-externalized String warnings Remove unused API problem filters Silence API errors Silence API errors Silence API warnings Change-Id: I71aa9f890c5eb05849ad16a00b9974da5e51171e