summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* JGit v6.8.0.202310031045-m1v6.8.0.202310031045-m1Matthias Sohn2023-10-0391-125/+125
| | | | | Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Change-Id: Ida0108f3661213922b1e4340216d60a640a1b662
* UploadPack: Delay freeing refs in sendPack()Ivan Frade2023-09-281-5/+5
| | | | | | | | | | | | | | | | Change [1] set refs to null at the beggining of sendPack claiming they are not needed anymore, but they are still used few lines below to hoist referenced objects to the front of the pack. With refs nullified, the hoist doesn't happened. This hasn't caused any problem so far, probably because it is just an optimization and the objects are in the pack anyway. Move the nullification after the hoisting to keep the optimization and save the memory. [1] https://git.eclipse.org/r/c/jgit/jgit/+/161341 Change-Id: I8455249d8482f616af362d3912b718064d473b49
* Merge "Fix log level for successful execution of ShutdownHook#notify to debug"Thomas Wolf2023-09-261-1/+1
|\
| * Fix log level for successful execution of ShutdownHook#notify to debugMatthias Sohn2023-09-261-1/+1
| | | | | | | | | | | | This is debug trace and shouldn't be logged as a warning. Change-Id: Ibb24e91e857a05aa6b74b0e2c5b11ab057f6206a
* | ByteBufferInputStream: add missing @since 6.8Thomas Wolf2023-09-261-0/+2
|/ | | | Change-Id: I80574a514ade608b87bed2dae79851e53a850c31 Signed-off-by: Thomas Wolf <twolf@apache.org>
* Eclipse features: update copyright yearThomas Wolf2023-09-269-9/+9
| | | | | | Set upper bound to 2023. Change-Id: I67acc12b3fe80ab7ca4a9303b0e96325a1e707e9 Signed-off-by: Thomas Wolf <twolf@apache.org>
* SSH agent: correct plug-in titleThomas Wolf2023-09-261-1/+1
| | | | | | | It's not only "Unix SSH agent" support, but also for Windows. Drop "Unix". Change-Id: I22deb3e5750825a70c78eec46b1f2968544857b9 Signed-off-by: Thomas Wolf <twolf@apache.org>
* Fix DefaultCharset bug pattern flagged by error proneDavid Ostrovsky2023-09-251-1/+3
| | | | | | | | See more details in: [1]. [1] https://errorprone.info/bugpattern/DefaultCharset Change-Id: Ib6aa279f9dcf63dff0672df5b5be3ea72597b1d8
* Activate additional error prone checksDavid Ostrovsky2023-09-251-12/+340
| | | | | Change-Id: I1b351e04da9f08681f08aae9ce984c3d3285e88e Signed-off-by: David Ostrovsky <david@ostrovsky.org>
* WorkingTreeIterator: directly filter input streamMatthias Sohn2023-09-255-18/+296
| | | | | | | | This way we can avoid to access the byte buffers backing array. Implement a ByteBufferInputStream to wrap a byte buffer which we can use to expose the filter result as an input stream. Change-Id: I461c82090de2562ea9b649b3f953aad4571e3d25
* [errorprone] Add missing javadoc summaryMatthias Sohn2023-09-25112-190/+1180
| | | | | | see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment Change-Id: Iaf4a6b55d4e4c59b7a2da3451164abb1bb47d4a1
* [errorprone] Fix BadImportMatthias Sohn2023-09-2516-74/+55
| | | | | | See https://errorprone.info/bugpattern/BadImport Change-Id: Iea98b15862ed0bc4bcad759a7240133769680808
* [errorprone] Prevent int expression may overflowMatthias Sohn2023-09-258-9/+9
| | | | | | see https://errorprone.info/bugpattern/IntLongMath Change-Id: Id201b7fc49b953d500e88b95e183127fe40ef6cc
* [errorprone] Suppress ByteBufferBackingArrayMatthias Sohn2023-09-253-0/+6
| | | | | | | | The byte buffers used here are created by wrapping a byte[]. See https://errorprone.info/bugpattern/ByteBufferBackingArray Change-Id: Idbc16d5ae4ff9f64b97be07a3cdf190716da191f
* [errorprone] Suppress JavaLangClash to avoid breaking changeMatthias Sohn2023-09-254-0/+8
| | | | | | | | | Renaming this class is a breaking change. Add a todo to rename it in next major release. See https://errorprone.info/bugpattern/JavaLangClash Change-Id: I3528fd654e30d98f4ea43e71107d83324942141c
* [errorprone] Fix EqualsGetClassMatthias Sohn2023-09-251-1/+1
| | | | | | See https://errorprone.info/bugpattern/EqualsGetClass Change-Id: Ida19a7e60656f87518e5ae2ef5eae511edb5b837
* [errorprone] MockSystemReader: fix CatchAndPrintStackTraceMatthias Sohn2023-09-251-1/+1
| | | | | | | See https://errorprone.info/bugpattern/CatchAndPrintStackTrace Change-Id: If1ec66ea65eaef9311a650d8a5741a03ac76cb88 Change-Id: Ic52205bab141a4e3c6a9fefecf749f1ccfc0e491
* [errorprone] MetaFilter: fix IdentityHashMapUsageMatthias Sohn2023-09-251-2/+1
| | | | | | See https://errorprone.info/bugpattern/IdentityHashMapUsage Change-Id: Ib49c2ca5506ea7468d2680faba254fa9cd430c2c
* [errorprone] InternalFetchConnection: Suppress CatchAndPrintStackTraceMatthias Sohn2023-09-251-0/+1
| | | | | | | | Handled by the client side pipe handling. See https://errorprone.info/bugpattern/CatchAndPrintStackTrace Change-Id: I4ae19dbd0d20d1a75b6587ce7ad36f58cb58dbc2
* [errorprone] Don't swallow exceptionMatthias Sohn2023-09-251-1/+1
| | | | | | See https://errorprone.info/bugpattern/UnusedException Change-Id: I01568dfa22adbbaa50191aa2d0a445a3c252b803
* [errorprone] Fix inconsistent capitalizationMatthias Sohn2023-09-254-16/+16
| | | | | | See https://errorprone.info/bugpattern/InconsistentCapitalization Change-Id: I5eaa35a053aca738e180fe22a05fad97877b7e0f
* [errorprone] PageRef#isStringRef: suppress UnusedMethodMatthias Sohn2023-09-251-0/+1
| | | | | | See https://errorprone.info/bugpattern/UnusedMethod Change-Id: I8c2ca60ac786e20edb7112c268d638aa2488bcb8
* [errorprone] FileReftableStack: fix EqualsUnsafeCastMatthias Sohn2023-09-251-0/+3
| | | | | | See https://errorprone.info/bugpattern/EqualsUnsafeCast Change-Id: I23274c1850061f0574133f52692e125cfa6b92ff
* [errorprone] Suppress MissingSummary for translation bundlesMatthias Sohn2023-09-2514-0/+14
| | | | Change-Id: I4da51c7e089366b016a0cc64f768a151c24bc956
* [errorprone] CommandLineMergeTool: Remove unused constuctorMatthias Sohn2023-09-251-5/+0
| | | | | | See https://errorprone.info/bugpattern/UnusedMethod Change-Id: I711279d7b81c61111c7c129b3d119affc515fe70
* [errorprone] SimilarityRenameDetector: suppress IntLongMathMatthias Sohn2023-09-251-0/+2
| | | | | | | | Indexes are positiv. See https://errorprone.info/bugpattern/IntLongMath Change-Id: I9ef90b3667f833e2d708ff608929990e0a09036c
* Add comment why protocol list uses WeakReferenceMatthias Sohn2023-09-251-0/+1
| | | | Change-Id: I997933cbf1bcae94a6edd9db58c25ec1bb96445f
* [errorprone] Transport: Suppress ModifyCollectionInEnhancedForLoopMatthias Sohn2023-09-251-4/+11
| | | | | | | | | | CopyOnWriteArrayList is thread-safe. See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/CopyOnWriteArrayList.html https://errorprone.info/bugpattern/ModifyCollectionInEnhancedForLoop Change-Id: I97c411e7d171cb39a9c0676b076d48103db6ff88
* [errorprone] Rename method parameter to silence InvalidParamMatthias Sohn2023-09-252-6/+6
| | | | | | See https://errorprone.info/bugpattern/InvalidParam Change-Id: I53279bc5e0fc59788d42994be9931857b918414b
* [errorprone] MyersDiff#main: fix CatchAndPrintStackTraceMatthias Sohn2023-09-251-2/+12
| | | | | | | | Use a PrintWriter similarly like Main#run of org.eclipse.jgit.pgm does. See https://errorprone.info/bugpattern/CatchAndPrintStackTrace Change-Id: I8ee34da53d94ddb72b73ae86bfebc3b7f0a3dc04
* [errorprone] TagCommand: Remove unused parameter of private methodMatthias Sohn2023-09-251-8/+2
| | | | | | See https://errorprone.info/bugpattern/UnusedVariable Change-Id: I7e8aae3494ce60dbeb474f6bead0817c36276e69
* [errorprone] PathFilter#getPathsBestEffort: fix ArrayAsKeyOfSetOrMapMatthias Sohn2023-09-251-3/+3
| | | | | | See https://errorprone.info/bugpattern/ArrayAsKeyOfSetOrMap Change-Id: Ia94899bfa68db39f4eb8bfca455c92f5c888647c
* [errorprone] DirCacheEntry: suppress JavaInstantGetSecondsGetNanoMatthias Sohn2023-09-251-0/+1
| | | | | | | | We get the seconds in the line before we access nanos. See https://errorprone.info/bugpattern/JavaInstantGetSecondsGetNano Change-Id: If79690378d5b31d76b06d26e07434d3dff8c92fb
* [errorprone] Directly implement functional interfaceMatthias Sohn2023-09-251-29/+31
| | | | | | | | | instead of saving it in a lambda. Prefer to implement the functional interface method directly and use a method reference instead. See https://errorprone.info/bugpattern/UnnecessaryLambda Change-Id: I7f7ebd27cd6354545c157960718d9845882e1732
* [errorprone] InterruptTimer#terminate: ensure Thread#join succeedsMatthias Sohn2023-09-251-3/+13
| | | | | | See https://errorprone.info/bugpattern/ThreadJoinLoop Change-Id: Ia67a284311a156c22c18575470ee5fbf734e10cc
* [errorprone] RawParseUtils@parseHexInt64: suppress IntLongMathMatthias Sohn2023-09-251-0/+1
| | | | | | see https://errorprone.info/bugpattern/IntLongMath Change-Id: I71acd5eec252b8c43d7c411f513e502694830727
* [errorprone] Exceptions should not override #toStringMatthias Sohn2023-09-252-8/+8
| | | | | | | | | Instead of overriding #toString provide getter for additional information so that code handling the exception can access it. See https://errorprone.info/bugpattern/OverrideThrowableToString Change-Id: Ie577ae9327e0234d55481253f2604b1644ea3f01
* [errorprone] Fix invalid param in javadocMatthias Sohn2023-09-254-10/+13
| | | | | | See https://errorprone.info/bugpattern/InvalidParam Change-Id: Ife74575bb4080c3386affbfbaf9373931d72c3f3
* [errorprone] FS#searchPath: handle surprising behavior of String#splitMatthias Sohn2023-09-252-1/+29
| | | | | | See https://errorprone.info/bugpattern/StringSplitter Change-Id: Ic80f6c53ea96537ed4d046621e774288fced7ce1
* [errorprone] FileStoreAttributes#FUTURE_RUNNER: Fix corePoolSizeMatthias Sohn2023-09-221-1/+1
| | | | | | | | | [ErroneousThreadPoolConstructorChecker] Thread pool size will never go beyond corePoolSize if an unbounded queue is used. see https://errorprone.info/bugpattern/ErroneousThreadPoolConstructorChecker Change-Id: Icdeaffa05301567611682da86130440f863f2ecc
* [errorprone] Express duration using seconds which is clearerMatthias Sohn2023-09-221-1/+1
| | | | | | | | | [CanonicalDuration] Duration can be expressed more clearly with different units. see https://errorprone.info/bugpattern/CanonicalDuration Change-Id: I7f358b5adabee1523e56b109a2c81c74ec523b74
* [errorprone] Use ArrayList instead of LinkedListMatthias Sohn2023-09-223-10/+12
| | | | | | | | [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. see https://errorprone.info/bugpattern/JdkObsolete Change-Id: I13fb953f55fc7b6e007d6fd6a6a1bfd377773588
* [errorprone] AddCommand#filepattern: use a more specific typeMatthias Sohn2023-09-221-2/+2
| | | | | | | | | | Variable type can use a more specific type to convey more information to callers. private Collection<String> filepatterns; ^ (see https://errorprone.info/bugpattern/PreferredInterfaceType) Change-Id: I68b74de65aba3bb849ef508d7dcdd8b85b0ab100
* [errorprone] Suppress UnnecessaryParenthesesMatthias Sohn2023-09-222-0/+3
| | | | | | | | for the sake of readability. See https://errorprone.info/bugpattern/UnnecessaryParentheses Change-Id: I8444db78c408d4e8bd71bf7e575b9af637900629
* [errorprone] Remove unnecessary parenthesesMatthias Sohn2023-09-2218-26/+24
| | | | | | see https://errorprone.info/bugpattern/UnnecessaryParentheses Change-Id: Id08cf0e05b3d35f139fc34e0aa83882555a8a81a
* tools/BUILD: Sort errorprone rules alphabeticallyMatthias Sohn2023-09-221-7/+7
| | | | Change-Id: I006940eb8a7710d5b8ea66c6f805f0dd08e62a31
* Update jetty to 10.0.16Matthias Sohn2023-09-2216-127/+127
| | | | Change-Id: I918e308e71fa978c9f25e3fad63c5f2e94ec3be7
* Update bazel to 6.3.2Matthias Sohn2023-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | With bazel 6.2.0 building the change I918e308e71fa978c9f25e3fad63c5f2e94ec3be7 fails with this error: $ bazelisk build all INFO: Invocation ID: ba94402e-d1db-4920-ad46-58139ef7ca55 INFO: Analyzed target //:all (96 packages loaded, 1961 targets configured). INFO: Found 1 target... ERROR: /Users/xxxxxxx/.cache/bazel/b645215973ac043930fa5900e337e822/external/jetty-util-ajax/jar/BUILD:3:12: Extracting interface @jetty-util-ajax//jar:jar failed: (Segmentation fault): ijar failed: error executing command (from target @jetty-util-ajax//jar:jar) external/remote_java_tools_darwin_arm64/java_tools/ijar/ijar external/jetty-util-ajax/jar/jetty-util-ajax-10.0.16.jar ... (remaining 3 arguments skipped) ... Updating bazel to 6.3.2 fixes this problem. Release notes for bazel 6.3.2: https://github.com/bazelbuild/bazel/releases/tag/6.3.2 Change-Id: I4f697b2f9a560732c89e2a0410ae6133e8c382ef
* DfsPackFile: remove unnecessary @SuppressWarnings("boxing")Matthias Sohn2023-09-221-8/+0
| | | | Change-Id: I7af999dc4434b7b57bb7e0b84b9b64d24efce220
* CommitGraphWriter: Remove unnecessary semicolonMatthias Sohn2023-09-221-1/+1
| | | | Change-Id: I8ea87d0ff3be8a541e72210f0da7fec1f43008e8
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-14 06:52:50 +0000