summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | [errorprone] MockSystemReader: fix CatchAndPrintStackTraceMatthias Sohn2023-09-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/CatchAndPrintStackTrace Change-Id: If1ec66ea65eaef9311a650d8a5741a03ac76cb88 Change-Id: Ic52205bab141a4e3c6a9fefecf749f1ccfc0e491
* | | | | | | | | | [errorprone] MetaFilter: fix IdentityHashMapUsageMatthias Sohn2023-09-251-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/IdentityHashMapUsage Change-Id: Ib49c2ca5506ea7468d2680faba254fa9cd430c2c
* | | | | | | | | | [errorprone] InternalFetchConnection: Suppress CatchAndPrintStackTraceMatthias Sohn2023-09-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Handled by the client side pipe handling. See https://errorprone.info/bugpattern/CatchAndPrintStackTrace Change-Id: I4ae19dbd0d20d1a75b6587ce7ad36f58cb58dbc2
* | | | | | | | | | [errorprone] Don't swallow exceptionMatthias Sohn2023-09-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/UnusedException Change-Id: I01568dfa22adbbaa50191aa2d0a445a3c252b803
* | | | | | | | | | [errorprone] Fix inconsistent capitalizationMatthias Sohn2023-09-254-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/InconsistentCapitalization Change-Id: I5eaa35a053aca738e180fe22a05fad97877b7e0f
* | | | | | | | | | [errorprone] PageRef#isStringRef: suppress UnusedMethodMatthias Sohn2023-09-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/UnusedMethod Change-Id: I8c2ca60ac786e20edb7112c268d638aa2488bcb8
* | | | | | | | | | [errorprone] FileReftableStack: fix EqualsUnsafeCastMatthias Sohn2023-09-251-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/EqualsUnsafeCast Change-Id: I23274c1850061f0574133f52692e125cfa6b92ff
* | | | | | | | | | [errorprone] Suppress MissingSummary for translation bundlesMatthias Sohn2023-09-2514-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I4da51c7e089366b016a0cc64f768a151c24bc956
* | | | | | | | | | [errorprone] CommandLineMergeTool: Remove unused constuctorMatthias Sohn2023-09-251-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/UnusedMethod Change-Id: I711279d7b81c61111c7c129b3d119affc515fe70
* | | | | | | | | | [errorprone] SimilarityRenameDetector: suppress IntLongMathMatthias Sohn2023-09-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Indexes are positiv. See https://errorprone.info/bugpattern/IntLongMath Change-Id: I9ef90b3667f833e2d708ff608929990e0a09036c
* | | | | | | | | | Add comment why protocol list uses WeakReferenceMatthias Sohn2023-09-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I997933cbf1bcae94a6edd9db58c25ec1bb96445f
* | | | | | | | | | [errorprone] Transport: Suppress ModifyCollectionInEnhancedForLoopMatthias Sohn2023-09-251-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CopyOnWriteArrayList is thread-safe. See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/CopyOnWriteArrayList.html https://errorprone.info/bugpattern/ModifyCollectionInEnhancedForLoop Change-Id: I97c411e7d171cb39a9c0676b076d48103db6ff88
* | | | | | | | | | [errorprone] Rename method parameter to silence InvalidParamMatthias Sohn2023-09-252-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/InvalidParam Change-Id: I53279bc5e0fc59788d42994be9931857b918414b
* | | | | | | | | | [errorprone] MyersDiff#main: fix CatchAndPrintStackTraceMatthias Sohn2023-09-251-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a PrintWriter similarly like Main#run of org.eclipse.jgit.pgm does. See https://errorprone.info/bugpattern/CatchAndPrintStackTrace Change-Id: I8ee34da53d94ddb72b73ae86bfebc3b7f0a3dc04
* | | | | | | | | | [errorprone] TagCommand: Remove unused parameter of private methodMatthias Sohn2023-09-251-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/UnusedVariable Change-Id: I7e8aae3494ce60dbeb474f6bead0817c36276e69
* | | | | | | | | | [errorprone] PathFilter#getPathsBestEffort: fix ArrayAsKeyOfSetOrMapMatthias Sohn2023-09-251-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/ArrayAsKeyOfSetOrMap Change-Id: Ia94899bfa68db39f4eb8bfca455c92f5c888647c
* | | | | | | | | | [errorprone] DirCacheEntry: suppress JavaInstantGetSecondsGetNanoMatthias Sohn2023-09-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We get the seconds in the line before we access nanos. See https://errorprone.info/bugpattern/JavaInstantGetSecondsGetNano Change-Id: If79690378d5b31d76b06d26e07434d3dff8c92fb
* | | | | | | | | | [errorprone] Directly implement functional interfaceMatthias Sohn2023-09-251-29/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of saving it in a lambda. Prefer to implement the functional interface method directly and use a method reference instead. See https://errorprone.info/bugpattern/UnnecessaryLambda Change-Id: I7f7ebd27cd6354545c157960718d9845882e1732
* | | | | | | | | | [errorprone] InterruptTimer#terminate: ensure Thread#join succeedsMatthias Sohn2023-09-251-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/ThreadJoinLoop Change-Id: Ia67a284311a156c22c18575470ee5fbf734e10cc
* | | | | | | | | | [errorprone] RawParseUtils@parseHexInt64: suppress IntLongMathMatthias Sohn2023-09-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | see https://errorprone.info/bugpattern/IntLongMath Change-Id: I71acd5eec252b8c43d7c411f513e502694830727
* | | | | | | | | | [errorprone] Exceptions should not override #toStringMatthias Sohn2023-09-252-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of overriding #toString provide getter for additional information so that code handling the exception can access it. See https://errorprone.info/bugpattern/OverrideThrowableToString Change-Id: Ie577ae9327e0234d55481253f2604b1644ea3f01
* | | | | | | | | | [errorprone] Fix invalid param in javadocMatthias Sohn2023-09-254-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/InvalidParam Change-Id: Ife74575bb4080c3386affbfbaf9373931d72c3f3
* | | | | | | | | | [errorprone] FS#searchPath: handle surprising behavior of String#splitMatthias Sohn2023-09-252-1/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://errorprone.info/bugpattern/StringSplitter Change-Id: Ic80f6c53ea96537ed4d046621e774288fced7ce1
* | | | | | | | | | [errorprone] FileStoreAttributes#FUTURE_RUNNER: Fix corePoolSizeMatthias Sohn2023-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ErroneousThreadPoolConstructorChecker] Thread pool size will never go beyond corePoolSize if an unbounded queue is used. see https://errorprone.info/bugpattern/ErroneousThreadPoolConstructorChecker Change-Id: Icdeaffa05301567611682da86130440f863f2ecc
* | | | | | | | | | [errorprone] Express duration using seconds which is clearerMatthias Sohn2023-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [CanonicalDuration] Duration can be expressed more clearly with different units. see https://errorprone.info/bugpattern/CanonicalDuration Change-Id: I7f358b5adabee1523e56b109a2c81c74ec523b74
* | | | | | | | | | [errorprone] Use ArrayList instead of LinkedListMatthias Sohn2023-09-223-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. see https://errorprone.info/bugpattern/JdkObsolete Change-Id: I13fb953f55fc7b6e007d6fd6a6a1bfd377773588
* | | | | | | | | | [errorprone] AddCommand#filepattern: use a more specific typeMatthias Sohn2023-09-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Variable type can use a more specific type to convey more information to callers. private Collection<String> filepatterns; ^ (see https://errorprone.info/bugpattern/PreferredInterfaceType) Change-Id: I68b74de65aba3bb849ef508d7dcdd8b85b0ab100
* | | | | | | | | | [errorprone] Suppress UnnecessaryParenthesesMatthias Sohn2023-09-222-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for the sake of readability. See https://errorprone.info/bugpattern/UnnecessaryParentheses Change-Id: I8444db78c408d4e8bd71bf7e575b9af637900629
* | | | | | | | | | [errorprone] Remove unnecessary parenthesesMatthias Sohn2023-09-2218-26/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | see https://errorprone.info/bugpattern/UnnecessaryParentheses Change-Id: Id08cf0e05b3d35f139fc34e0aa83882555a8a81a
* | | | | | | | | | tools/BUILD: Sort errorprone rules alphabeticallyMatthias Sohn2023-09-221-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I006940eb8a7710d5b8ea66c6f805f0dd08e62a31
* | | | | | | | | | Update jetty to 10.0.16Matthias Sohn2023-09-2216-127/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I918e308e71fa978c9f25e3fad63c5f2e94ec3be7
* | | | | | | | | | Update bazel to 6.3.2Matthias Sohn2023-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With bazel 6.2.0 building the change I918e308e71fa978c9f25e3fad63c5f2e94ec3be7 fails with this error: $ bazelisk build all INFO: Invocation ID: ba94402e-d1db-4920-ad46-58139ef7ca55 INFO: Analyzed target //:all (96 packages loaded, 1961 targets configured). INFO: Found 1 target... ERROR: /Users/xxxxxxx/.cache/bazel/b645215973ac043930fa5900e337e822/external/jetty-util-ajax/jar/BUILD:3:12: Extracting interface @jetty-util-ajax//jar:jar failed: (Segmentation fault): ijar failed: error executing command (from target @jetty-util-ajax//jar:jar) external/remote_java_tools_darwin_arm64/java_tools/ijar/ijar external/jetty-util-ajax/jar/jetty-util-ajax-10.0.16.jar ... (remaining 3 arguments skipped) ... Updating bazel to 6.3.2 fixes this problem. Release notes for bazel 6.3.2: https://github.com/bazelbuild/bazel/releases/tag/6.3.2 Change-Id: I4f697b2f9a560732c89e2a0410ae6133e8c382ef
* | | | | | | | | | DfsPackFile: remove unnecessary @SuppressWarnings("boxing")Matthias Sohn2023-09-221-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I7af999dc4434b7b57bb7e0b84b9b64d24efce220
* | | | | | | | | | CommitGraphWriter: Remove unnecessary semicolonMatthias Sohn2023-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I8ea87d0ff3be8a541e72210f0da7fec1f43008e8
* | | | | | | | | | CommitGraphWriter: fix boxing warningsMatthias Sohn2023-09-223-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I35c3a3baadb8d7d73c01252fe4333fa2159722ee
* | | | | | | | | | CommitGraphWriter#createCoreChunks: Remove not-thrown exceptionsMatthias Sohn2023-09-221-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I0e6f32ed415dc3a0ccadbeae46c979c378ebb0fc
* | | | | | | | | | CommitGraphWriter: Decouple Stats from computing bloom filtersIvan Frade2023-09-211-9/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The public stats object is created only to be populated by the computation of bloom filters. Make the computation return its numbers with the results and copy them to the stats when needed. This eliminates the side effects from the computation and makes it easier to add more data to the stats later. Change-Id: I7a5e55fc3a17f5a294edf3a3b725b2d9c0280a5a
* | | | | | | | | | CommitGraphWriter: Move bloom filter calculation out of createChunksIvan Frade2023-09-201-5/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It looks confusing that the createChunks method calculates bloom filters. Make the calculations before and pass the result to the method. Change-Id: If6e3c0e644f7f940f268ca7266f577f012278ff3
* | | | | | | | | | Documentation: Move writeChangedPaths flag from commitGraph to gc section.Ronald Bhuleskar2023-09-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The flag commitGraph.writeChangedPaths is not correct. The option was introduced in commit 3b77e33 (Jul 19th) under gc section so updating the documentation to reflect it under correct section. Change-Id: Ie8f82931594ed3fd1ee3e4532d2e7475878a33a1
* | | | | | | | | | [errorprone] Fix wrong comparison which always evaluated to falseMatthias Sohn2023-09-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/GraphObjectIndex.java:59: error: [ComparisonOutOfRange] ints may have a value in the range -2147483648 to 2147483647; therefore, this comparison to Integer.MAX_VALUE will always evaluate to false if (table[k] > Integer.MAX_VALUE) { ^ See https://errorprone.info/bugpattern/ComparisonOutOfRange We need to check if variable `uint` of type `long` exceeds the maximum possible int value before casting it to `int` below. This was introduced in Ib5c0d6678cb242870a0f5841bd413ad3885e95f6 Change-Id: I675d594f523084be4c1678328cc343065e32d998
* | | | | | | | | | [errorprone] Remove unnecessary comparisonMatthias Sohn2023-09-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Raised by errorprone: org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitConfig.java:406: error: [ComparisonOutOfRange] chars may have a value in the range 0 to 65535; therefore, this comparison to 0 will always evaluate to true if (ch >= 0 && ch < inUse.length) { ^ see https://errorprone.info/bugpattern/ComparisonOutOfRange Change-Id: I9625aa7894a34dbffd77d39a40c6e285c86b56d5
* | | | | | | | | | Update org.eclipse.jdt:ecj to 3.35.0Matthias Sohn2023-09-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ic1d7fe65a0255bc0cdaf7a7285dd3532277ec07b
* | | | | | | | | | Update org.apache.commons:commons-compress to 1.24.0Matthias Sohn2023-09-1516-30/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I896298f9e94b50dda6c6396e652f4a191a722a68
* | | | | | | | | | [errorprone] Suppress ImmutableEnumChecker for ShutdownHookMatthias Sohn2023-09-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here we use enum to implement a singleton. Hence suppress the errorprone error ImmutableEnumChecker. Change-Id: I21f6ed83c08936dfc9aa591af809e69f3053a050
* | | | | | | | | | Update bytebuddy to 1.14.8Matthias Sohn2023-09-1515-44/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I60ad9ea9300099eeabbb5023d7a5264593e60dc0
* | | | | | | | | | Use ShutdownHook to gracefully handle JVM shutdownMatthias Sohn2023-09-126-54/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in all classes which already registered their own shutdown hook - CloneCommand - GC#PidLock - FS#FileStoreAttributes - LocalDiskRepositoryTestCase#Cleanup Change-Id: I3efc1f83f3cbbf43eeeaaedcd2bee1ef31971a72
* | | | | | | | | | Add ShutdownHook to cleanup FileLocks on graceful JVM shutdownMatthias Sohn2023-09-124-0/+161
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should avoid stale lock files if the JVM is terminated gracefully. Implement a ShutdownHook which can register/unregister listeners which need to do some cleanup during graceful JVM shutdown. This hook is registered as a Java shutdown hook and when the JVM shuts down calls #onShutdown of registered listeners using a parallel stream to let them run concurrently. See https://docs.oracle.com/javase/8/docs/technotes/guides/lang/hook-design.html Bug: 582379 Change-Id: I1621dc5f7d9a8c832b6d1b74cbc47578b1c2f0b8
* | | | | | | | | | Unregister ShutdownHook when GC#PidLock is closedMatthias Sohn2023-09-121-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise the JVM will accumulate the ShutdownHook objects of all GCs run while the JVM is up. Change-Id: Iadc723a939238a3a75b4ba47f898918eb4554ea3
* | | | | | | | | | Merge "OSGi: move plugin localization to subdirectory"Matthias Sohn2023-09-1249-37/+51
|\ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | OSGi: move plugin localization to subdirectoryThomas Wolf2023-09-1249-37/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OSGi can have its plugin localization at an arbitrary place; there is no need to have it in a top-level plugin.properties file. In non-OSGi environments having the files at the root level may mean that these files clash with each other, or, as in the referenced bug, with some third-party plug-in's plugin.properties, which may not even have anything to do with localization. Move our OSGi localization to a subfolder OSGI-INF/l10n. For OSGi environments, that's just as good, and for non-OSGi environments it avoid clashes with other root level items on the classpath or in a fat JAR. For fragments, use neither plugin.properties (which would clash with the host plug-in's plugin.properties) nor fragment.properties (which might clash with other fragments for the same fragment host bundle). Instead use names "relative" to the host bundle. Bug: 582394 Change-Id: Ifbcd046d912e2cfe86c0f7259c5ca8de599d9aa1 Signed-off-by: Thomas Wolf <twolf@apache.org>
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-15 09:07:06 +0000