aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix javadoc in org.eclipse.jgit patch and revplot packageMatthias Sohn2017-12-1910-61/+236
| | | | Change-Id: I6f1aba98bf7034cb51494c546806cf1b72dd1473 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit nls and notes packageMatthias Sohn2017-12-198-71/+94
| | | | Change-Id: I1b65fba5b4856f98974dc10f549540d401ef916f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit merge packageMatthias Sohn2017-12-1916-105/+209
| | | | Change-Id: I735d0f2e9f10531ed43b7b3dd6314c574392422f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit lib packageMatthias Sohn2017-12-1964-550/+1215
| | | | Change-Id: I1e85a951488177993521ce177fdea212615e6164 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit storage/reftree packageMatthias Sohn2017-12-198-37/+105
| | | | Change-Id: Ie206b5340ad2019a1e0bd2bcede2c1e5a279f2d5 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit storage/reftable packageMatthias Sohn2017-12-1911-57/+215
| | | | Change-Id: I14764c5d5b2309d82fe2ccc0593120b51328bf41 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit storage/pack packageMatthias Sohn2017-12-1910-125/+258
| | | | Change-Id: Id1b7d392e1bb36079edaf16450e73a044a318e7e Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit storage/io packageMatthias Sohn2017-12-191-2/+3
| | | | Change-Id: I2db781311af79510b26fd05cc0556623e75e3eff Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit storage/file packageMatthias Sohn2017-12-1950-166/+473
| | | | Change-Id: Ieb2f66aef2cab7e2a6d8e35c5f5047da881994dd Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit dfs packageMatthias Sohn2017-12-1938-160/+647
| | | | Change-Id: I1f5e3dc3ba34b323ee7244dbefee207ce19e6021 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* StoredObjectRepresentationNotAvailableException: Add TODO to fix API in 5.0David Pursehouse2017-12-191-1/+1
| | | | | Change-Id: I9a0e6acac1b88ddf257fe7b2b7d0142be20250ea Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* StoredObjectRepresentationNotAvailableException: Add constructor that takes ↵David Pursehouse2017-12-192-4/+17
| | | | | | | | | | | | | | cause If the cause can be passed into the constructor, callers don't need to instantiate it and then explicitly call initCause. Note that the constructors in this class cause "non-API parameter type" warnings because ObjectToPack is internal, however it's probably OK since the only non-internal reference to it is in the pgm.debug package. Change-Id: Ia4eab24e79f9afe6214ea8160137d941d4048319 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Merge changes Ifc34e96a,I72be0a0dDavid Pursehouse2017-12-1820-130/+386
|\ | | | | | | | | | | * changes: Fix javadoc in org.eclipse.jgit rewalk package Fix javadoc in org.eclipse.jgit ketch package
| * Fix javadoc in org.eclipse.jgit rewalk packageMatthias Sohn2017-12-182-0/+6
| | | | | | | | Change-Id: Ifc34e96a56df30e3b73bef812eea943623af7906 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| * Fix javadoc in org.eclipse.jgit ketch packageMatthias Sohn2017-12-1818-130/+380
| | | | | | | | Change-Id: I72be0a0d5ac7d3e957597803bd103dbbec141ba4
* | Config: Rewrite subsection and value escaping and parsingDave Borowitz2017-12-185-123/+307
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, Config was using the same method for both escaping and parsing subsection names and config values. The goal was presumably code savings, but unfortunately, these two pieces of the git config format are simply different. In git v2.15.1, Documentation/config.txt says the following about subsection names: "Subsection names are case sensitive and can contain any characters except newline (doublequote `"` and backslash can be included by escaping them as `\"` and `\\`, respectively). Section headers cannot span multiple lines. Variables may belong directly to a section or to a given subsection." And, later in the same documentation section, about values: "A line that defines a value can be continued to the next line by ending it with a `\`; the backquote and the end-of-line are stripped. Leading whitespaces after 'name =', the remainder of the line after the first comment character '#' or ';', and trailing whitespaces of the line are discarded unless they are enclosed in double quotes. Internal whitespaces within the value are retained verbatim. Inside double quotes, double quote `"` and backslash `\` characters must be escaped: use `\"` for `"` and `\\` for `\`. The following escape sequences (beside `\"` and `\\`) are recognized: `\n` for newline character (NL), `\t` for horizontal tabulation (HT, TAB) and `\b` for backspace (BS). Other char escape sequences (including octal escape sequences) are invalid." The main important differences are that subsection names have a limited set of supported escape sequences, and do not support newlines at all, either escaped or unescaped. Arguably, it would be easy to support escaped newlines, but C git simply does not: $ git config -f foo.config $'foo.bar\nbaz.quux' value error: invalid key (newline): foo.bar baz.quux I468106ac was an attempt to fix one bug in escapeValue, around leading whitespace, without having to rewrite the whole escaping/parsing code. Unfortunately, because escapeValue was used for escaping subsection names as well, this made it possible to write invalid config files, any time Config#toText is called with a subsection name with trailing whitespace, like {foo }. Rather than pile hacks on top of hacks, fix it for real by largely rewriting the escaping and parsing code. In addition to fixing escape sequences, fix (and write tests for) a few more issues in the old implementation: * Now that we can properly parse it, always emit newlines as "\n" from escapeValue, rather than the weird (but still supported) syntax with a non-quoted trailing literal "\n\" before the newline. In addition to producing more readable output and matching the behavior of C git, this makes the escaping code much simpler. * Disallow '\0' entirely within both subsection names and values, since due to Unix command line argument conventions it is impossible to pass such values to "git config". * Properly preserve intra-value whitespace when parsing, rather than collapsing it all to a single space. Change-Id: I304f626b9d0ad1592c4e4e449a11b136c0f8b3e3
* Fix javadoc in org.eclipse.jgit internal and fsck packagesMatthias Sohn2017-12-183-9/+54
| | | | Change-Id: Ib12da10aacda9389d594bf4f521e9a58d1935701 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit ignore packageMatthias Sohn2017-12-1811-16/+55
| | | | Change-Id: I1a81d371420cd4cf90ab9e048026c0ab8a763018 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit hooks packageMatthias Sohn2017-12-186-7/+54
| | | | Change-Id: I3b644048eb0fc19f94ba8f9799b5a2310481103f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit gitrepo packageMatthias Sohn2017-12-184-6/+49
| | | | Change-Id: I2604c7bca87f005004d6d6c80fa9a39a7a1e3807 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit fnmatch packageMatthias Sohn2017-12-188-11/+44
| | | | Change-Id: I14384c3bf3c41f8e1c62ec117837c2fc782a832f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit events packageMatthias Sohn2017-12-1812-26/+66
| | | | Change-Id: Ifcb9c67daeb9da84a1461a4f731523ac5df3a223 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit errors packageMatthias Sohn2017-12-1831-47/+156
| | | | Change-Id: I46aa5c3073b99a311a1a97fc57d8f29d32524482 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit dircache packageMatthias Sohn2017-12-1810-92/+153
| | | | Change-Id: Ib485eb217ac6be70519816f8cc0396931043a3d1 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* EmtpyCommitException: Add TODO to fix misspelled class name in 5.0David Pursehouse2017-12-181-1/+1
| | | | | Change-Id: I5bb145d6d6cbaaa2d8cfb2febad7a008ca921236 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Merge "PushConnectionTest: Increase maxCommandBytes yet again"Christian Halstrick2017-12-181-1/+1
|\
| * PushConnectionTest: Increase maxCommandBytes yet againDavid Pursehouse2017-12-181-1/+1
| | | | | | | | | | | | | | | | | | It was already increased in 61a943e and 661232b but is still not enough to take into account snapshot versions that are 100 or more commits ahead of tag, i.e. 4.9.2.201712150930-r.105-gc1d37ca27 Change-Id: Ibeff73adae06b92fe5bb9c5eced9e4c6a08c437c Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* | Merge changes I7162d729,I2761ea91David Pursehouse2017-12-18115-883/+1720
|\ \ | | | | | | | | | | | | | | | * changes: Fix javadoc org.eclipse.jgit diff package Fix javadoc in org.eclipse.jgit annotations and api packages
| * | Fix javadoc org.eclipse.jgit diff packageMatthias Sohn2017-12-1822-160/+333
| | | | | | | | | | | | Change-Id: I7162d72916abc8533ad37e8b17335ff4a70d6519 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| * | Fix javadoc in org.eclipse.jgit annotations and api packagesMatthias Sohn2017-12-1893-723/+1387
| | | | | | | | | | | | Change-Id: I2761ea91f8dfed16ea54e7a6646af03a30c15ec9 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | | Merge "Repeat: Fix javadoc to say 'annotation' instead of 'interface'"Christian Halstrick2017-12-181-1/+1
|\ \ \ | | |/ | |/|
| * | Repeat: Fix javadoc to say 'annotation' instead of 'interface'David Pursehouse2017-12-181-1/+1
| | | | | | | | | | | | | | | Change-Id: Ib0c4ec28d6b7e2fc0fe71f7dc53dd12ccd6e8a2f Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* | | Merge "Remove redundant @SuppressWarnings("unused")"Christian Halstrick2017-12-182-9/+5
|\| |
| * | Remove redundant @SuppressWarnings("unused")David Pursehouse2017-12-182-9/+5
| | | | | | | | | | | | | | | | | | | | | These are now redundant since the parameters have javadoc. Change-Id: I6bfde267e1712ee35871c30c8203c3b4dc5e136a Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* | | Merge "PathTreeFilterHandler: Remove unused import"Christian Halstrick2017-12-181-1/+0
|\| | | |/ |/|
| * PathTreeFilterHandler: Remove unused importDavid Pursehouse2017-12-181-1/+0
| | | | | | | | | | Change-Id: I7a91210dcb775d0c9b46772f8ff3d84196ba3b10 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* | Fix javadoc in org.eclipse.jgit blame packageMatthias Sohn2017-12-175-31/+100
| | | | | | | | Change-Id: I116dacc7f4ace341ec6ffae2ab96b53496d89f64 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* | Fix javadoc in org.eclipse.jgit attributes packageMatthias Sohn2017-12-1710-81/+171
|/ | | | Change-Id: I12968f4be805266f285a518a014b8bd1d0c23bae Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.uiMatthias Sohn2017-12-186-5/+31
| | | | Change-Id: Iec68c73fc0d8d26fdb26850354059ea521ac7fe5 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.pgmMatthias Sohn2017-12-1876-42/+329
| | | | Change-Id: I74616f6e8ef69bef4db2f13a9b47ddf57714fd1f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.lfs.serverMatthias Sohn2017-12-1711-66/+98
| | | | Change-Id: I0c52536ebeeb8e71d95c6420f6db7055ff082dfa Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.lfsMatthias Sohn2017-12-1724-84/+190
| | | | Change-Id: I97b53c083da6aa31719d9e10369030ee33dd23dc Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.junitMatthias Sohn2017-12-1711-22/+323
| | | | | Change-Id: I1107e6a82849ac329361baabb5c481d86ea6dc9e Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.junit.httpMatthias Sohn2017-12-177-16/+284
| | | | | Change-Id: I8af6d07676a285f79635405e5891535a5adfd7e9 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.http.testMatthias Sohn2017-12-172-3/+7
| | | | | Change-Id: Ibd18dfed05d35bd70498d11c04c026a34114a87e Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.http.serverMatthias Sohn2017-12-1731-64/+204
| | | | | Change-Id: I732d773b21bbf64285493070964dd9e442eab5d8 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.http.apacheMatthias Sohn2017-12-174-7/+52
| | | | | Change-Id: I38a4854856b0103790a410b48c1c3d708b6500c1 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.archiveMatthias Sohn2017-12-178-40/+45
| | | | | Change-Id: Ibef80b15f17e884f3085e324283cefc738236a4d Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Fix javadoc in org.eclipse.jgit.antMatthias Sohn2017-12-174-1/+22
| | | | | Change-Id: I97231080ebe040ad44f7189de6109b9626424d2f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
* Upgrade maven-javadoc-plugin to 3.0.0David Pursehouse2017-12-161-1/+3
| | | | | | | | | | | This version seems to be much stricter and reports a lot more errors in the javadoc formatting. Disable failOnError to prevent the build from failing due to these newly reported problems. These should be fixed in a follow-up commit. Change-Id: Ia403cbedf72cfe8bdaf09f30e42e3bf96084ae52 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>