summaryrefslogtreecommitdiffstats
path: root/tools/BUILD
Commit message (Collapse)AuthorAgeFilesLines
* Increase severity of OperatorPrecedence to ERROR, and fix instancesDavid Pursehouse2019-06-121-1/+1
| | | | | | | | Fix all remaining instances of the OperatorPrededence warning, by adding parentheses to make the precedence explicit. Change-Id: Ib296dfed09f9be042d0ff0f7fad8214e4dd766b4 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Merge branch 'master' into stable-5.4Matthias Sohn2019-06-111-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Handle missing "ours" stage in WorkingTreeIterator.hasCrLfInIndex() Config: Add helper method to check for empty value ErrorProne: Increase severity of FutureReturnValueIgnored to ERROR FS_Win32: Add missing parentheses on if-blocks Upgrade spotbugs to 3.1.12 Abbreviated{Long}ObjectId: Make operator precedence explicit GC: Update TODO comments FS_POSIX: Fix reference comparison of Boolean.FALSE Increase bazel timeout for long running tests Use bazelisk to switch between used bazel version Bump minimum Bazel version to 0.26.1 Bazel: Bump skylib library version to 0.8.0 Retry loading config when locked by another process Make pull --rebase on an unborn branch do a checkout Warn if configured cookie file is missing Handle escaped CR-LF in git config files DescribeCommand: use glob match instead of path match Fix off-by-one error in RebaseTodoFile when reading a todo file Consistently use "!isEmpty()" to detect non-empty list TransportHttp: Check for non-empty list with "!isEmpty()" rather than "size() > 0" TransportHttp: Fix comparison of size with ">= 0" NetscapeCookieFileTest: Split HttpCookiesMatcher to own class Bazel: Add missing dependency on mockito for TransportHttpTest Determine hard-linking and nlink support per FileStore Support reading and writing cookies. Repository: Add getIdentifier() method to avoid instanceof operator Update to Orbit R20190602212107 PacketLineIn: Deprecate the END constant PacketLineIn: Add an iterator over strings in the input stream Replace most usages of PacketLineIn.END with PacketLineIn.end() PacketLineIn: Deprecate DELIM constant Replace trivial reference comparison of PacketLineIn.{DELIM,END} PacketLineIn: Rename isDelim to isDelimiter ProtocolV2ParserTest: Fix typo in comment Upgrade Bouncy Castle to 1.61 Update to Orbit R20190531194818 and rollback update to Ant 1.10.6 cli: Add the --always option to describe DescribeCommand: Support the "always" option cli: Add the --tags option to describe DescribeCommand: Consistenly omit the default value Remove excess blank line in FileUtilsTest PacketLineIn: Add helper methods to check for END and DELIM UploadPackTest: Rename variable to avoid hiding class member UploadPackTest: Add missing <> operator on instantiation of ArrayList BitmapCalculator: javadoc fixes RevWalkUtils: add progress callback to findBranchesReachableFrom Upgrade maven-source-plugin to 3.1.0 Upgrade maven-jar-plugin to 3.1.2 Upgrade jacoco-maven-plugin to 0.8.4 BitmapCalculator and its test: add missing license header RevWalk: new method createReachabilityChecker() Change-Id: I4d76c7c0dbe6411c842f3468b709f7df51789c08 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
| * ErrorProne: Increase severity of FutureReturnValueIgnored to ERRORDavid Pursehouse2019-06-111-1/+1
| | | | | | | | | | | | | | | | The only remaining code where the return value is ignored is in tests. Update them to store the value and perform a basic assertion. Change-Id: I29ef5bd5dd0648aac3490f9e47ecc74544109652 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* | Bazel: Increase severity of most error-prone checks to ERRORDavid Pursehouse2019-05-261-39/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the checks can be increased to ERROR because there is no code in the project that triggers them. There are still several that are triggered, and these are left at the WARN severity: https://errorprone.info/bugpattern/AmbiguousMethodReference https://errorprone.info/bugpattern/BadComparable https://errorprone.info/bugpattern/ClassNewInstance https://errorprone.info/bugpattern/Finally https://errorprone.info/bugpattern/FutureReturnValueIgnored https://errorprone.info/bugpattern/ImmutableEnumChecker https://errorprone.info/bugpattern/NarrowingCompoundAssignment https://errorprone.info/bugpattern/NonOverridingEquals https://errorprone.info/bugpattern/OperatorPrecedence https://errorprone.info/bugpattern/ReferenceEquality https://errorprone.info/bugpattern/ShortCircuitBoolean https://errorprone.info/bugpattern/StringEquality https://errorprone.info/bugpattern/TypeParameterUnusedInFormals These can be cleaned up and increased to ERROR in follow-up commits. Change-Id: Icfc3b3163e129e504f10b3fc856aef262f723f99 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* | Enable error-prone checks by defaultDavid Pursehouse2019-05-261-1/+3
|/ | | | | | | | | | | | | | Based on recent work by Dave Borowitz on the Gerrit project [1, 2]. The warnings/error configuration is unchanged, but now the checks are enabled by default during the build rather than having to be manually invoked. [1] https://gerrit-review.googlesource.com/c/gerrit/+/225653 [2] https://gerrit-review.googlesource.com/c/gerrit/+/225714 Change-Id: I7f4849896af72de38880b13d64519cc93bb3d2a3 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Bazel: Increase severity of ClassCanBeStatic to ERRORDavid Pursehouse2018-11-081-1/+1
| | | | | Change-Id: I8250fd15cfff6bbba54a238be31b3cf772edab3f Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Bazel: Format tools/BUILD with buildifierDavid Pursehouse2018-11-061-6/+6
| | | | | Change-Id: I292613a0e40d2022bc68c6acbd45d37a54c1e613 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Upgrade to Bazel 0.19.0David Ostrovsky2018-11-011-1/+1
| | | | | | | | | Also replace native git_repository rule with Starlark rule. This is needed because in recent Bazel versions native git_repository rule is deprecated. Change-Id: I2c19fd31693a930d7d35fdbb93bfa4abf21fa2aa Signed-off-by: David Ostrovsky <david@ostrovsky.org>
* Bazel: Increase severity of DefaultCharset to ERRORDavid Pursehouse2018-09-301-1/+1
| | | | | | | | | All existing instances of this issue have been fixed in preceding commits. Increase its severity to ERROR so that it is easier to detect reoccurences. Change-Id: I50f95152857baac5ca44c15493f23b6f9cfac1bf Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Bazel: Increase severity of MissingFail to ERRORDavid Pursehouse2018-09-301-1/+1
| | | | | | | | | All instances of this potential bug have been cleaned up in preceding commits. Increase the severity to ERROR so that it is easier to detect reoccurences. Change-Id: I25beebcea1f01f468e0f2b1d24a83511029c077c Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Bazel: Increase severity of ExpectedExceptionChecker to ERRORDavid Pursehouse2018-09-261-1/+1
| | | | | | | | | Incorrect usage of ExpectedException has been cleaned up in the preceding commits. Increase the severity from WARN to ERROR so that it is easier to catch any reoccurences. Change-Id: I57decf620b37e85413bda53723f839c02b488f2c Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Bazel: Provide toolchain with activated error prone warningsDavid Ostrovsky2018-09-221-0/+107
| | | | | | | | | | | | | | | | | | On recent bazel versions it's trivial to apply package specific checks. Provide custom java toolchain with all error prone warnings activated. The list of all error prone warnings was borrowed from here: [1]. Test Plan: $ bazel build --java_toolchain //tools:error_prone_warnings_toolchain \ //... [1] https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl Change-Id: I207a368555bfb7ddab8d782d46d563ce779a6211 Signed-off-by: David Ostrovsky <david@ostrovsky.org> Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
* Implement initial framework of Bazel buildDavid Ostrovsky2017-01-181-0/+0
The initial implementation only builds the packages consumed by Gerrit Code Review. Test build and execution is not implemented. We prefer to consume maven_jar custom rule from bazlets repository, for the same reasons as in the Gerrit project: * Caching artifacts across different clones and projects * Exposing source classifiers and neverlink artifact TEST PLAN: $ bazel build :all $ unzip -t bazel-genfiles/all.zip Archive: bazel-genfiles/all.zip testing: libjgit-archive.jar OK testing: libjgit-servlet.jar OK testing: libjgit.jar OK testing: libjunit.jar OK No errors detected in compressed data of bazel-genfiles/all.zip. Change-Id: Ia837ce95d9829fe2515f37b7a04a71a4598672a0 Signed-off-by: David Ostrovsky <david@ostrovsky.org> Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-25 16:35:18 +0000