From 9dc1ddf324c0f5ff37cd3ff47c8b16595012004b Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 7 Jun 2019 10:57:15 +0900 Subject: TransportHttp: Fix comparison of size with ">= 0" Error Prone reports: [SizeGreaterThanOrEqualsZero] Comparison of a size >= 0 is always true, did you intend to check for non-emptiness? see https://errorprone.info/bugpattern/SizeGreaterThanOrEqualsZero Change-Id: Ie964771cacca4b15569eb45f6e273ad2a7e2e49c Signed-off-by: David Pursehouse --- org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java index f44a99b8b4..88349a7ee5 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java @@ -952,7 +952,7 @@ public class TransportHttp extends HttpTransport implements WalkTransport, cookieHeaderValue.append(cookie.toString()); } } - if (cookieHeaderValue.length() >= 0) { + if (cookieHeaderValue.length() > 0) { conn.setRequestProperty(HDR_COOKIE, cookieHeaderValue.toString()); } } -- cgit v1.2.3