From 408d4b5375c4731a83e2f091d62d05157abcb21e Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Wed, 1 Sep 2010 09:20:33 -0700 Subject: Add reset() to AbstractTreeIterator API This allows callers to force the iterator back to its starting point, so it can be traversed again. The default way to do this is to use back(1) until first() is true, but this isn't very efficient for any iterator. All current implementations have better ways to implement reset without needing to seek backwards. Change-Id: Ia26e6c852fdac8a0e9c80ac72c8cca9d897463f4 Signed-off-by: Shawn O. Pearce --- .../src/org/eclipse/jgit/dircache/DirCacheIterator.java | 9 +++++++++ .../org/eclipse/jgit/treewalk/AbstractTreeIterator.java | 16 ++++++++++++++++ .../org/eclipse/jgit/treewalk/CanonicalTreeParser.java | 6 ++++++ .../src/org/eclipse/jgit/treewalk/EmptyTreeIterator.java | 5 +++++ .../org/eclipse/jgit/treewalk/WorkingTreeIterator.java | 9 +++++++++ 5 files changed, 45 insertions(+) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheIterator.java b/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheIterator.java index b4e2d2c2dd..aa8d9fb85d 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheIterator.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheIterator.java @@ -159,6 +159,15 @@ public class DirCacheIterator extends AbstractTreeIterator { return 0; } + @Override + public void reset() { + if (!first()) { + ptr = treeStart; + if (!eof()) + parseEntry(); + } + } + @Override public boolean first() { return ptr == treeStart; diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/AbstractTreeIterator.java b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/AbstractTreeIterator.java index a54b3e9cfa..eee62c63a5 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/AbstractTreeIterator.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/AbstractTreeIterator.java @@ -496,6 +496,22 @@ public abstract class AbstractTreeIterator { return createSubtreeIterator(reader); } + /** + * Position this iterator on the first entry. + * + * The default implementation of this method uses {@code back(1)} until + * {@code first()} is true. This is most likely not the most efficient + * method of repositioning the iterator to its first entry, so subclasses + * are strongly encouraged to override the method. + * + * @throws CorruptObjectException + * the tree is invalid. + */ + public void reset() throws CorruptObjectException { + while (!first()) + back(1); + } + /** * Is this tree iterator positioned on its first entry? *

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/CanonicalTreeParser.java b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/CanonicalTreeParser.java index 8e4094a055..01b8274253 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/CanonicalTreeParser.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/CanonicalTreeParser.java @@ -243,6 +243,12 @@ public class CanonicalTreeParser extends AbstractTreeIterator { return nextPtr - Constants.OBJECT_ID_LENGTH; } + @Override + public void reset() { + if (!first()) + reset(raw); + } + @Override public boolean first() { return currPtr == 0; diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/EmptyTreeIterator.java b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/EmptyTreeIterator.java index 7d4ee6d2bd..49d75871e8 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/EmptyTreeIterator.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/EmptyTreeIterator.java @@ -107,6 +107,11 @@ public class EmptyTreeIterator extends AbstractTreeIterator { return 0; } + @Override + public void reset() { + // Do nothing. + } + @Override public boolean first() { return true; diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/WorkingTreeIterator.java b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/WorkingTreeIterator.java index 5256e8aae9..51c3483699 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/WorkingTreeIterator.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/treewalk/WorkingTreeIterator.java @@ -332,6 +332,15 @@ public abstract class WorkingTreeIterator extends AbstractTreeIterator { return 0; } + @Override + public void reset() { + if (!first()) { + ptr = 0; + if (!eof()) + parseEntry(); + } + } + @Override public boolean first() { return ptr == 0; -- cgit v1.2.3